diff options
| author | Tsuchiya Yuto <kitakar@gmail.com> | 2021-10-18 01:19:44 +0900 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-11-15 08:11:36 +0000 |
| commit | 9f6b4fa2d2dfbff4b8a57eeb39b1128a6094ee20 (patch) | |
| tree | 5de26db7e458a3a489f2dc675df0c2797db9c211 /tools/perf/scripts/python | |
| parent | e1921cd14640f0f4d1fad5eb8e448c58a536415d (diff) | |
| download | kernel-9f6b4fa2d2dfbff4b8a57eeb39b1128a6094ee20.tar.gz | |
media: atomisp: do not use err var when checking port validity for ISP2400
Currently, the `port >= N_CSI_PORTS || err` checks for ISP2400 are always
evaluated as true because the err variable is set to `-EINVAL` on
declaration but the variable is never used until the evaluation.
Looking at the diff of commit 3c0538fbad9f ("media: atomisp: get rid of
most checks for ISP2401 version"), the `port >= N_CSI_PORTS` check is
for ISP2400 and the err variable check is for ISP2401. Fix this issue
by adding ISP version test there accordingly.
Fixes: 3c0538fbad9f ("media: atomisp: get rid of most checks for ISP2401 version")
Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions
