summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/libxed.py
diff options
context:
space:
mode:
authorChao Yu <chao@kernel.org>2024-11-21 22:17:16 +0800
committerJaegeuk Kim <jaegeuk@kernel.org>2024-11-23 15:48:15 +0000
commitbc8aeb04fd80cb8cfae3058445c84410fd0beb5e (patch)
treedcd5d14adadcf5e00cd981bc924342a7380391d4 /tools/perf/scripts/python/libxed.py
parent009a8241a8e5a14ea2dd0b8db42dbf283527dd44 (diff)
downloadkernel-bc8aeb04fd80cb8cfae3058445c84410fd0beb5e.tar.gz
f2fs: fix to drop all discards after creating snapshot on lvm device
Piergiorgio reported a bug in bugzilla as below: ------------[ cut here ]------------ WARNING: CPU: 2 PID: 969 at fs/f2fs/segment.c:1330 RIP: 0010:__submit_discard_cmd+0x27d/0x400 [f2fs] Call Trace: __issue_discard_cmd+0x1ca/0x350 [f2fs] issue_discard_thread+0x191/0x480 [f2fs] kthread+0xcf/0x100 ret_from_fork+0x31/0x50 ret_from_fork_asm+0x1a/0x30 w/ below testcase, it can reproduce this bug quickly: - pvcreate /dev/vdb - vgcreate myvg1 /dev/vdb - lvcreate -L 1024m -n mylv1 myvg1 - mount /dev/myvg1/mylv1 /mnt/f2fs - dd if=/dev/zero of=/mnt/f2fs/file bs=1M count=20 - sync - rm /mnt/f2fs/file - sync - lvcreate -L 1024m -s -n mylv1-snapshot /dev/myvg1/mylv1 - umount /mnt/f2fs The root cause is: it will update discard_max_bytes of mounted lvm device to zero after creating snapshot on this lvm device, then, __submit_discard_cmd() will pass parameter @nr_sects w/ zero value to __blkdev_issue_discard(), it returns a NULL bio pointer, result in panic. This patch changes as below for fixing: 1. Let's drop all remained discards in f2fs_unfreeze() if snapshot of lvm device is created. 2. Checking discard_max_bytes before submitting discard during __submit_discard_cmd(). Cc: stable@vger.kernel.org Fixes: 35ec7d574884 ("f2fs: split discard command in prior to block layer") Reported-by: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219484 Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/libxed.py')
0 files changed, 0 insertions, 0 deletions
genet/bcmgenet.c?h=linux-6.12.y&id=484bfa1507bf71cecc7833ae7f7272d8af49badc'>Revert "net: bcmgenet: Software reset EPHY after power on"Doug Berger 2017-10-26net: bcmgenet: relax lock constraints to reduce IRQ latencyDoug Berger 2017-10-26net: bcmgenet: rework bcmgenet_netif_start and bcmgenet_netif_stopDoug Berger 2017-10-26net: bcmgenet: cleanup ring interrupt masking and unmaskingDoug Berger 2017-10-26net: bcmgenet: move NAPI initialization to ring initializationDoug Berger 2017-10-26net: bcmgenet: enable loopback during UniMAC sw_resetDoug Berger 2017-10-26net: bcmgenet: prevent duplicate calls of bcmgenet_dma_teardownDoug Berger 2017-10-26net: bcmgenet: correct bad mergeDoug Berger 2017-09-01Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/netDavid S. Miller 2017-08-29net: bcmgenet: Use correct I/O accessorsFlorian Fainelli 2017-08-24net: bcmgenet: Be drop monitor friendlyFlorian Fainelli 2017-07-31Revert "net: bcmgenet: Remove init parameter from bcmgenet_mii_config"Florian Fainelli 2017-07-15net: bcmgenet: Free skb after last Tx fragDoug Berger 2017-07-15net: bcmgenet: Fix unmapping of fragments in bcmgenet_xmit()Doug Berger 2017-06-13net: phy: Make phy_ethtool_ksettings_get return voidyuval.shaia@oracle.com