diff options
| author | Nathan Rebello <nathan.c.rebello@gmail.com> | 2026-03-13 18:24:53 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-04-11 14:29:56 +0200 |
| commit | 98429e9ec89a5e3a204112dfaa2dbe6ca28493a0 (patch) | |
| tree | 0e44a52c8d858c0605ccf38b4d114812beddecfa /drivers/hid/hid-appletb-kbd.c | |
| parent | 625a53ef398e2bff0d8796a7418eb7e0d4ef79b7 (diff) | |
usb: typec: ucsi: validate connector number in ucsi_notify_common()
commit d2d8c17ac01a1b1f638ea5d340a884ccc5015186 upstream.
The connector number extracted from CCI via UCSI_CCI_CONNECTOR() is a
7-bit field (0-127) that is used to index into the connector array in
ucsi_connector_change(). However, the array is only allocated for the
number of connectors reported by the device (typically 2-4 entries).
A malicious or malfunctioning device could report an out-of-range
connector number in the CCI, causing an out-of-bounds array access in
ucsi_connector_change().
Add a bounds check in ucsi_notify_common(), the central point where CCI
is parsed after arriving from hardware, so that bogus connector numbers
are rejected before they propagate further.
Fixes: bdc62f2bae8f ("usb: typec: ucsi: Simplified registration and I/O API")
Cc: stable <stable@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Nathan Rebello <nathan.c.rebello@gmail.com>
Link: https://patch.msgid.link/20260313222453.123-1-nathan.c.rebello@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hid/hid-appletb-kbd.c')
0 files changed, 0 insertions, 0 deletions
