summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaciej Strozek <mstrozek@opensource.cirrus.com>2026-04-08 10:38:31 +0100
committerMark Brown <broonie@kernel.org>2026-04-08 16:55:28 +0100
commit23e0cbe55736de222ed975863cf06baf29bee5fe (patch)
tree12cd1ca76c6f9ba17aacf676fc3f98c57345e845
parent0669631dbccd41cf3ca7aa70213fcd8bb41c4b38 (diff)
ASoC: SDCA: Fix overwritten var within for loop
mask variable should not be overwritten within the for loop or it will skip certain bits. Change to using BIT() macro. Fixes: b9ab3b618241 ("ASoC: SDCA: Add some initial IRQ handlers") Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://patch.msgid.link/20260408093835.2881486-2-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/sdca/sdca_interrupts.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/soc/sdca/sdca_interrupts.c b/sound/soc/sdca/sdca_interrupts.c
index 1838dabcdf60..9acb0be84674 100644
--- a/sound/soc/sdca/sdca_interrupts.c
+++ b/sound/soc/sdca/sdca_interrupts.c
@@ -117,9 +117,7 @@ static irqreturn_t function_status_handler(int irq, void *data)
status = val;
for_each_set_bit(mask, &status, BITS_PER_BYTE) {
- mask = 1 << mask;
-
- switch (mask) {
+ switch (BIT(mask)) {
case SDCA_CTL_ENTITY_0_FUNCTION_NEEDS_INITIALIZATION:
//FIXME: Add init writes
break;