diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2025-03-03 15:27:39 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-05-22 14:31:53 +0200 |
| commit | 914267b6927b9ef452b8f2184b27ce523b2db50c (patch) | |
| tree | e9101715621456b7513a74a36b72e065f278be46 /tools/perf/scripts/python/stackcollapse.py | |
| parent | 628bec9ed68a2204184fc8230a2609075b08666e (diff) | |
| download | kernel-914267b6927b9ef452b8f2184b27ce523b2db50c.tar.gz | |
phy: Fix error handling in tegra_xusb_port_init
commit b2ea5f49580c0762d17d80d8083cb89bc3acf74f upstream.
If device_add() fails, do not use device_unregister() for error
handling. device_unregister() consists two functions: device_del() and
put_device(). device_unregister() should only be called after
device_add() succeeded because device_del() undoes what device_add()
does if successful. Change device_unregister() to put_device() call
before returning from the function.
As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 53d2a715c240 ("phy: Add Tegra XUSB pad controller support")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20250303072739.3874987-1-make24@iscas.ac.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions
