diff options
| author | John Johansen <john.johansen@canonical.com> | 2025-11-14 00:14:36 -0800 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2026-03-04 07:20:40 -0500 |
| commit | d5eb32cf3e141c42f079d70bad31bd71e5db7b57 (patch) | |
| tree | c6e30f49d4cbecc18eeb8ff6ea95381a3e95a5de /security/apparmor | |
| parent | e43818b16815c0c2bf933ef28316f8e704e5e0ef (diff) | |
apparmor: remove apply_modes_to_perms from label_match
[ Upstream commit b2e27be2948f2f8c38421cd554b5fc9383215648 ]
The modes shouldn't be applied at the point of label match, it just
results in them being applied multiple times. Instead they should be
applied after which is already being done by all callers so it can
just be dropped from label_match.
Reviewed-by: Georgia Garcia <georgia.garcia@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Stable-dep-of: a4c9efa4dbad ("apparmor: make label_match return a consistent value")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'security/apparmor')
| -rw-r--r-- | security/apparmor/label.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/security/apparmor/label.c b/security/apparmor/label.c index c71e4615dd46..81548248440a 100644 --- a/security/apparmor/label.c +++ b/security/apparmor/label.c @@ -1329,7 +1329,6 @@ next: goto fail; } *perms = *aa_lookup_perms(rules->policy, state); - aa_apply_modes_to_perms(profile, perms); if ((perms->allow & request) != request) return -EACCES; @@ -1382,7 +1381,6 @@ static int label_components_match(struct aa_profile *profile, next: tmp = *aa_lookup_perms(rules->policy, state); - aa_apply_modes_to_perms(profile, &tmp); aa_perms_accum(perms, &tmp); label_for_each_cont(i, label, tp) { if (!aa_ns_visible(profile->ns, tp->ns, subns)) @@ -1391,7 +1389,6 @@ next: if (!state) goto fail; tmp = *aa_lookup_perms(rules->policy, state); - aa_apply_modes_to_perms(profile, &tmp); aa_perms_accum(perms, &tmp); } |