diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-09-21 19:21:51 +0300 |
|---|---|---|
| committer | Zefan Li <lizefan@huawei.com> | 2016-10-26 23:15:23 +0800 |
| commit | b8c196dd0a6ae60c6a687df2a81810706e64a091 (patch) | |
| tree | 9275bee1d73d794a3bd7869ecb2622c6289b0419 /lib/devres.c | |
| parent | 355c6a10ace105674b8b0b9c0eacec89395ac0d5 (diff) | |
devres: fix a for loop bounds check
commit 1f35d04a02a652f14566f875aef3a6f2af4cb77b upstream.
The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.
Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Diffstat (limited to 'lib/devres.c')
| -rw-r--r-- | lib/devres.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/devres.c b/lib/devres.c index 80b9c76d436a..584c2dcfcb03 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -390,7 +390,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) if (!iomap) return; - for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { + for (i = 0; i < PCIM_IOMAP_MAX; i++) { if (!(mask & (1 << i))) continue; |