summaryrefslogtreecommitdiff
path: root/lib/bootconfig-data.S
diff options
context:
space:
mode:
authorAntheas Kapenekakis <lkml@antheas.dev>2025-10-26 20:16:34 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-12-18 14:00:16 +0100
commitaa463ec2fff179a539d7f6e8c11c8fce57b7aa44 (patch)
tree79bed3f1b0db9a32582ae77a89e9231f2fe2c847 /lib/bootconfig-data.S
parent9287f7d96e614b45306b1f254e1d91e0a87e1560 (diff)
ALSA: hda/tas2781: fix speaker id retrieval for multiple probes
commit 945865a0ddf3e3950aea32e23e10d815ee9b21bc upstream. Currently, on ASUS projects, the TAS2781 codec attaches the speaker GPIO to the first tasdevice_priv instance using devm. This causes tas2781_read_acpi to fail on subsequent probes since the GPIO is already managed by the first device. This causes a failure on Xbox Ally X, because it has two amplifiers, and prevents us from quirking both the Xbox Ally and Xbox Ally X in the realtek codec driver. It is unnecessary to attach the GPIO to a device as it is static. Therefore, instead of attaching it and then reading it when loading the firmware, read its value directly in tas2781_read_acpi and store it in the private data structure. Then, make reading the value non-fatal so that ASUS projects that miss a speaker pin can still work, perhaps using fallback firmware. Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects") Cc: stable@vger.kernel.org # 6.17 Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> Reviewed-by: Baojun Xu <baojun.xu@ti.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://patch.msgid.link/20251026191635.2447593-1-lkml@antheas.dev Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/bootconfig-data.S')
0 files changed, 0 insertions, 0 deletions