diff options
| author | Jens Axboe <axboe@kernel.dk> | 2025-01-15 09:05:15 -0700 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2025-01-24 09:37:30 +0100 |
| commit | 5e0e02f0d7e52cfc8b1adfc778dd02181d8b47b4 (patch) | |
| tree | 585b1b169efa2c2a2d229f309a75d02e064d20c7 /io_uring/futex.c | |
| parent | bc8198dc7ebc492ec3e9fa1617dcdfbe98e73b17 (diff) | |
futex: Pass in task to futex_queue()
futex_queue() -> __futex_queue() uses 'current' as the task to store in
the struct futex_q->task field. This is fine for synchronous usage of
the futex infrastructure, but it's not always correct when used by
io_uring where the task doing the initial futex_queue() might not be
available later on. This doesn't lead to any issues currently, as the
io_uring side doesn't support PI futexes, but it does leave a
potentially dangling pointer which is never a good idea.
Have futex_queue() take a task_struct argument, and have the regular
callers pass in 'current' for that. Meanwhile io_uring can just pass in
NULL, as the task should never be used off that path. In theory
req->tctx->task could be used here, but there's no point populating it
with a task field that will never be used anyway.
Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/22484a23-542c-4003-b721-400688a0d055@kernel.dk
Diffstat (limited to 'io_uring/futex.c')
| -rw-r--r-- | io_uring/futex.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/futex.c b/io_uring/futex.c index 30139cc150f2..e5cc208810ad 100644 --- a/io_uring/futex.c +++ b/io_uring/futex.c @@ -338,7 +338,7 @@ int io_futex_wait(struct io_kiocb *req, unsigned int issue_flags) hlist_add_head(&req->hash_node, &ctx->futex_list); io_ring_submit_unlock(ctx, issue_flags); - futex_queue(&ifd->q, hb); + futex_queue(&ifd->q, hb, NULL); return IOU_ISSUE_SKIP_COMPLETE; } |