diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2023-01-31 16:01:45 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-05-17 11:50:20 +0200 |
| commit | e7ce4ba11635ef23aa7ad40b4b9f9c52ef15f9e2 (patch) | |
| tree | 3652109ecd4d72331af809c9dd5c3b0d270655e5 /include/crypto | |
| parent | a8cc4d5adfe5b6a9e7004e624dfe9a925727f871 (diff) | |
crypto: api - Add scaffolding to change completion function signature
[ Upstream commit c35e03eaece71101ff6cbf776b86403860ac8cc3 ]
The crypto completion function currently takes a pointer to a
struct crypto_async_request object. However, in reality the API
does not allow the use of any part of the object apart from the
data field. For example, ahash/shash will create a fake object
on the stack to pass along a different data field.
This leads to potential bugs where the user may try to dereference
or otherwise use the crypto_async_request object.
This patch adds some temporary scaffolding so that the completion
function can take a void * instead. Once affected users have been
converted this can be removed.
The helper crypto_request_complete will remain even after the
conversion is complete. It should be used instead of calling
the completion function directly.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Stable-dep-of: 4140aafcff16 ("crypto: engine - fix crypto_queue backlog handling")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/crypto')
| -rw-r--r-- | include/crypto/algapi.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h index 5f6841c73e5a..0ffd61930e18 100644 --- a/include/crypto/algapi.h +++ b/include/crypto/algapi.h @@ -256,4 +256,11 @@ enum { CRYPTO_MSG_ALG_LOADED, }; +static inline void crypto_request_complete(struct crypto_async_request *req, + int err) +{ + crypto_completion_t complete = req->complete; + complete(req, err); +} + #endif /* _CRYPTO_ALGAPI_H */ |