summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorThorsten Blum <thorsten.blum@linux.dev>2026-02-26 22:28:45 +0100
committerSasha Levin <sashal@kernel.org>2026-03-12 07:09:43 -0400
commit2ef0fc3bf49db2b9df36d5f44508c9e384bfa2a1 (patch)
treefe230a445ef24c65377bb799fa8d59286b1061fc /fs
parent134596a6e4be9eb025573c0472958d8cc7c97300 (diff)
smb: client: Don't log plaintext credentials in cifs_set_cifscreds
commit 2f37dc436d4e61ff7ae0b0353cf91b8c10396e4d upstream. When debug logging is enabled, cifs_set_cifscreds() logs the key payload and exposes the plaintext username and password. Remove the debug log to avoid exposing credentials. Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts") Cc: stable@vger.kernel.org Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/smb/client/connect.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
index d96d23a8f490..dd7f48f53097 100644
--- a/fs/smb/client/connect.c
+++ b/fs/smb/client/connect.c
@@ -2235,7 +2235,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struct cifs_ses *ses)
/* find first : in payload */
payload = upayload->data;
delim = strnchr(payload, upayload->datalen, ':');
- cifs_dbg(FYI, "payload=%s\n", payload);
if (!delim) {
cifs_dbg(FYI, "Unable to find ':' in payload (datalen=%d)\n",
upayload->datalen);