diff options
| author | Weigang He <geoffreyhe2@gmail.com> | 2026-01-16 09:57:51 +0000 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2026-03-04 07:20:24 -0500 |
| commit | 20881ad42e651c69d89eb38a2042838187900fd6 (patch) | |
| tree | d6c5f3b3ae2023e302444f00913b449893ec0d14 /drivers/video/fbdev/ffb.c | |
| parent | 9a9bc60ed372aaae9784ff8ad8e5f496ff15fd31 (diff) | |
fbdev: of: display_timing: fix refcount leak in of_get_display_timings()
[ Upstream commit eacf9840ae1285a1ef47eb0ce16d786e542bd4d7 ]
of_parse_phandle() returns a device_node with refcount incremented,
which is stored in 'entry' and then copied to 'native_mode'. When the
error paths at lines 184 or 192 jump to 'entryfail', native_mode's
refcount is not decremented, causing a refcount leak.
Fix this by changing the goto target from 'entryfail' to 'timingfail',
which properly calls of_node_put(native_mode) before cleanup.
Fixes: cc3f414cf2e4 ("video: add of helper for display timings/videomode")
Cc: stable@vger.kernel.org
Signed-off-by: Weigang He <geoffreyhe2@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/video/fbdev/ffb.c')
0 files changed, 0 insertions, 0 deletions
