diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-11-28 10:17:57 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-02-26 15:01:24 -0800 |
| commit | d25b326fafd81f26be0ff2262e0e6b7f4b99e182 (patch) | |
| tree | 351176647e36a502a6ebc914c734606caad5c299 /drivers/gpib | |
| parent | 4fa5be422d82ba38ef602085faf2b7d8b2d0dd99 (diff) | |
gpib: Fix error code in ni_usb_write_registers()
[ Upstream commit 484e62252212c5b5fc62eaee5e4977143cb159c6 ]
If ni_usb_receive_bulk_msg() succeeds but without reading 16 bytes, then
the error code needs to be set. The current code returns success.
Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSlMpbE4IrQuBGFS@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/gpib')
| -rw-r--r-- | drivers/gpib/ni_usb/ni_usb_gpib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb_gpib.c index 1f8412de9fa3..fdcaa6c00bfe 100644 --- a/drivers/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/gpib/ni_usb/ni_usb_gpib.c @@ -566,7 +566,7 @@ static int ni_usb_write_registers(struct ni_usb_priv *ni_priv, retval, bytes_read); ni_usb_dump_raw_block(in_data, bytes_read); kfree(in_data); - return retval; + return retval ?: -EINVAL; } mutex_unlock(&ni_priv->addressed_transfer_lock); |