summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>2026-01-26 12:46:54 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-02-06 16:40:12 +0100
commita8bb3ec8d85951a56af0a72d93ccbc2aee42eef9 (patch)
tree9ab020ccc469ceea2dfc36a85689dcfc8c4a1608
parent3b42020e6790a5e19b36c187ed5b488a5716f97f (diff)
scsi: xen: scsiback: Fix potential memory leak in scsiback_remove()
[ Upstream commit 901a5f309daba412e2a30364d7ec1492fa11c32c ] Memory allocated for struct vscsiblk_info in scsiback_probe() is not freed in scsiback_remove() leading to potential memory leaks on remove, as well as in the scsiback_probe() error paths. Fix that by freeing it in scsiback_remove(). Cc: stable@vger.kernel.org Fixes: d9d660f6e562 ("xen-scsiback: Add Xen PV SCSI backend driver") Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://patch.msgid.link/20251223063012.119035-1-nihaal@cse.iitm.ac.in Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> [ adapted void scsiback_remove() to int return type with return 0 statement ] Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/xen/xen-scsiback.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 9cd4fe8ce680..fd0ce2f6bbe4 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -1202,6 +1202,7 @@ static int scsiback_remove(struct xenbus_device *dev)
gnttab_page_cache_shrink(&info->free_pages, 0);
dev_set_drvdata(&dev->dev, NULL);
+ kfree(info);
return 0;
}