diff options
| author | Yan, Zheng <zyan@redhat.com> | 2018-06-19 18:20:34 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-08-24 13:06:51 +0200 |
| commit | 3aebfca49f9e2d73c028dc94f92d8af025155f3f (patch) | |
| tree | 95969aee2dee8aa2362c1daf3debaff2b4ae1512 | |
| parent | 788a2c75a32d68d6adf583ad4a7ee1bfe7de0ad6 (diff) | |
ceph: fix dentry leak in splice_dentry()
[ Upstream commit 8b8f53af1ed9df88a4c0fbfdf3db58f62060edf3 ]
In any case, d_splice_alias() does not drop reference of original
dentry.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ceph/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index ae056927080d..6b6868d0cdcc 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -1123,6 +1123,7 @@ static struct dentry *splice_dentry(struct dentry *dn, struct inode *in) if (IS_ERR(realdn)) { pr_err("splice_dentry error %ld %p inode %p ino %llx.%llx\n", PTR_ERR(realdn), dn, in, ceph_vinop(in)); + dput(dn); dn = realdn; /* note realdn contains the error */ goto out; } else if (realdn) { |