diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-06-20 13:45:05 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-08-24 13:06:45 +0200 |
| commit | 2e95d2eac6d45fd148f06f8dc4da257fe866f018 (patch) | |
| tree | 5ba604a8fc5b64ec4bc07059bf727244e3d05c43 | |
| parent | cf10109138be1779448b133cfc2a7e933c43ff7e (diff) | |
blk-mq-debugfs: Off by one in blk_mq_rq_state_name()
[ Upstream commit a1e79188628580465ac6d7a93a313336ee3364f1 ]
If rq_state == ARRAY_SIZE() then we read one element beyond the end of
the blk_mq_rq_state_name_array[] array.
Fixes: ec6dcf63c55c ("blk-mq-debugfs: Show more request state information")
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | block/blk-mq-debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 3080e18cb859..62b5f3f21b4b 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -357,7 +357,7 @@ static const char *const blk_mq_rq_state_name_array[] = { static const char *blk_mq_rq_state_name(enum mq_rq_state rq_state) { - if (WARN_ON_ONCE((unsigned int)rq_state > + if (WARN_ON_ONCE((unsigned int)rq_state >= ARRAY_SIZE(blk_mq_rq_state_name_array))) return "(?)"; return blk_mq_rq_state_name_array[rq_state]; |