summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChien Tin Tung <chien.tin.tung@intel.com>2018-03-21 13:09:25 -0500
committerBen Hutchings <ben@decadent.org.uk>2018-06-01 00:30:23 +0100
commitb5f21d80f536b5987ff6e209e6d57d4e39c2caab (patch)
treec6aec64433fa9e48f5c3a80a14c96bd97d894179
parentb37e09dd6279b2d04ab8ca7a0d7058d48e494c18 (diff)
RDMA/ucma: Correct option size check using optlen
commit 5f3e3b85cc0a5eae1c46d72e47d3de7bf208d9e2 upstream. The option size check is using optval instead of optlen causing the set option call to fail. Use the correct field, optlen, for size check. Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size") Signed-off-by: Chien Tin Tung <chien.tin.tung@intel.com> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com> Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--drivers/infiniband/core/ucma.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 550b81e2c1c0..99295c3e85ac 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1009,7 +1009,7 @@ static ssize_t ucma_set_option(struct ucma_file *file, const char __user *inbuf,
if (IS_ERR(ctx))
return PTR_ERR(ctx);
- if (unlikely(cmd.optval > KMALLOC_MAX_SIZE))
+ if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE))
return -EINVAL;
optval = kmalloc(cmd.optlen, GFP_KERNEL);