summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Bires <jbires@google.com>2017-01-03 08:18:07 -0800
committerJiri Slaby <jslaby@suse.cz>2017-04-28 19:30:47 +0200
commit1b991103f0a363e22001fd479fa90d27cf6c9381 (patch)
tree4495849c805ee251538df2e837d0aeb415083dd0
parent932ae8d926eeb0b2247a52df21c9f3b2c4de7fcb (diff)
char: lack of bool string made CONFIG_DEVPORT always on
commit f2cfa58b136e4b06a9b9db7af5ef62fbb5992f62 upstream. Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires <jbires@google.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
-rw-r--r--drivers/char/Kconfig5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 0070872c1441..a961133e2aa2 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -567,9 +567,12 @@ config TELCLOCK
controlling the behavior of this hardware.
config DEVPORT
- bool
+ bool "/dev/port character device"
depends on ISA || PCI
default y
+ help
+ Say Y here if you want to support the /dev/port device. The /dev/port
+ device is similar to /dev/mem, but for I/O ports.
source "drivers/s390/char/Kconfig"