kernel/tools/usb/usbip/src, branch linux-5.1.y

usbip: usbip_detach: fix to check for invalid ports

2018-05-31T10:44:39Z

usbip detach doesn't check for invalid ports and ports that are already detached. It attempts to remove state file(s) without validating the port and sends detach request to the driver for ports that are already detached. Add check for invalid ports (port > maxports) and ports that are already detached (status == VDEV_ST_NULL). Don't remove state files and don't send detach request for invalid ports and ports that are already detached. Add error and information messages that make sense. Signed-off-by: Shuah Khan (Samsung OSG) Signed-off-by: Greg Kroah-Hartman

usbip: usbip_detach: Fix memory, udev context and udev leak

2018-05-31T10:44:39Z

detach_port() fails to call usbip_vhci_driver_close() from its error path after usbip_vhci_detach_device() returns failure, leaking memory allocated in usbip_vhci_driver_open() and holding udev_context and udev references. Fix it to call usbip_vhci_driver_close(). Signed-off-by: Shuah Khan (Samsung OSG) Signed-off-by: Greg Kroah-Hartman

usbip: tools: usbipd: exclude exported devices from exportable device list

2018-03-22T12:08:20Z

usbipd includes exported devices in response to exportable device list. Exclude exported devices from exportable device list to avoid: - import requests for devices that are exported only to fail the request. - revealing devices that are imported by a client to another client. Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

usbip: tools: change to use new error codes in server reply messages

2018-03-09T17:17:09Z

Changed usbip_network, usbip_attach, usbip_list, and usbipd to use and propagate the new error codes in server reply messages. usbip_net_recv_op_common() is changed to take a pointer to status return the status returned in the op_common.status to callers. usbip_attach and usbip_list use the common interface to print error messages to indicate why the request failed. With this change the messages say why a request failed: - when a client requests a device that is already exported: usbip attach -r server_name -b 3-10.2 usbip: error: Attach Request for 3-10.2 failed - Device busy (exported) - when a client requests a device that isn't exportable, usbip attach -r server_name -b 3-10.4 usbip: error: Attach Request for 3-10.4 failed - Device not found Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

usbip: tools: add more error codes for usbip request/reply messages

2018-03-09T17:17:08Z

Currently ST_OK and ST_NA are the only values defined to communicate status of a request from a client. Add more error codes to clearly indicate what failed. For example, when client sends request to import a device that isn't export-able, server can send a specific error code to the client. Existing defines are moved to a common header in libsrc to be included in the libusbip_la-usbip_common.o to be used by all the usbip tools. Supporting interface to print error strings is added to the common lib. Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

usbip: tools usbip_network: Fix cryptic error messages

2018-03-09T17:16:20Z

Kernel and tool version mismatch message is cryptic. Fix it to be informative. Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

usbip: tools usbip_attach: Fix cryptic error messages

2018-03-09T17:16:19Z

Attach device error message is cryptic and useless. Fix it to be informative. Signed-off-by: Shuah Khan Reviewed-by: Krzysztof Opasiak Signed-off-by: Greg Kroah-Hartman

usbip: list: don't list devices attached to vhci_hcd

2018-01-22T14:34:37Z

usbip host lists devices attached to vhci_hcd on the same server when user does attach over localhost or specifies the server as the remote. usbip attach -r localhost -b busid or usbip attach -r servername (or server IP) Fix it to check and not list devices that are attached to vhci_hcd. Cc: stable@vger.kernel.org Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

usbip: prevent bind loops on devices attached to vhci_hcd

2018-01-22T14:34:37Z

usbip host binds to devices attached to vhci_hcd on the same server when user does attach over localhost or specifies the server as the remote. usbip attach -r localhost -b busid or usbip attach -r servername (or server IP) Unbind followed by bind works, however device is left in a bad state with accesses via the attached busid result in errors and system hangs during shutdown. Fix it to check and bail out if the device is already attached to vhci_hcd. Cc: stable@vger.kernel.org Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman

Merge 4.15.0-rc6 into usb-next

2018-01-02T14:13:41Z

We want the USB fixes in here, and this resolves a merge issue with the vhci_rx.c file. Signed-off-by: Greg Kroah-Hartman