kernel/tools/testing/selftests/bpf/prog_tests, branch linux-5.1.yHosts the 0x221E linux distro kernel.https://universe.0xinfinity.dev/distro/kernel/atom?h=linux-5.1.y2019-04-03T14:49:48Zselftests/bpf: fix vlan handling in flow dissector program2019-04-03T14:49:48ZStanislav Fomichevsdf@google.com2019-04-01T20:57:30Zurn:sha1:2c3af7d901c61c101c02f431cfb520af9ff56ab4
When we tail call PROG(VLAN) from parse_eth_proto we don't need to peek
back to handle vlan proto because we didn't adjust nhoff/thoff yet. Use
flow_keys->n_proto, that we set in parse_eth_proto instead and
properly increment nhoff as well.
Also, always use skb->protocol and don't look at skb->vlan_present.
skb->vlan_present indicates that vlan information is stored out-of-band
in skb->vlan_{tci,proto} and vlan header is already pulled from skb.
That means, skb->vlan_present == true is not relevant for BPF flow
dissector.
Add simple test cases with VLAN tagged frames:
* single vlan for ipv4
* double vlan for ipv6
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
selftests/bpf: fix segfault of test_progs when prog loading failed2019-03-12T20:55:54ZYonghong Songyhs@fb.com2019-03-12T05:21:09Zurn:sha1:d6f1837107c00fa7b2fdb606acf65b33b455dbfd
The test_progs subtests, test_spin_lock() and test_map_lock(),
requires BTF present to run successfully.
Currently, when BTF failed to load, test_progs will segfault,
$ ./test_progs
...
12: (bf) r1 = r8
13: (85) call bpf_spin_lock#93
map 'hash_map' has to have BTF in order to use bpf_spin_lock
libbpf: -- END LOG --
libbpf: failed to load program 'map_lock_demo'
libbpf: failed to load object './test_map_lock.o'
test_map_lock:bpf_prog_load errno 13
Segmentation fault
The segfault is caused by uninitialized variable "obj", which
is used in bpf_object__close(obj), when bpf prog failed to load.
Initializing variable "obj" to NULL in two occasions fixed the problem.
$ ./test_progs
...
Summary: 219 PASSED, 2 FAILED
Fixes: b4d4556c3266 ("selftests/bpf: add bpf_spin_lock verifier tests")
Fixes: ba72a7b4badb ("selftests/bpf: test for BPF_F_LOCK")
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Yonghong Song <yhs@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
selftests: bpf: test_progs: initialize duration in singal_pending test2019-03-07T09:46:25ZStanislav Fomichevsdf@google.com2019-03-06T23:25:26Zurn:sha1:69b09175d68241cb96ff9433d8e7a17382d720d6
CHECK macro implicitly uses duration. We call CHECK() a couple of times
before duration is initialized from bpf_prog_test_run().
Explicitly set duration to 0 to avoid compiler warnings.
Fixes: 740f8a657221 ("selftests/bpf: make sure signal interrupts BPF_PROG_TEST_RUN")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
selftests: bpf: break up test_progs - misc2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:19Zurn:sha1:886225bb0868fcf763bea62d18e57e4b5ef08a42
Move the rest of prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - spinlock2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:18Zurn:sha1:271a6337cbaedfa9b93006326d0ecc28fd3dc71c
Move spinlock prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - tracepoint2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:17Zurn:sha1:20cb14ff9c49fcb189daf82246fb6fcd3923542c
Move tracepoint prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - stackmap2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:16Zurn:sha1:615741d81de6c16aa466c4eb37805caa868a9bb8
Move stackmap prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - xdp2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:15Zurn:sha1:eaf90740f5ad054b1962f32a50e5b7476c0f16bd
Move xdp prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - pkt access2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:14Zurn:sha1:7395724b404db76fc093fb99b5c957baa409d8ae
Move pkt access prog tests into separate files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
selftests: bpf: break up test_progs - preparations2019-03-02T19:10:40ZStanislav Fomichevsdf@google.com2019-03-02T03:42:13Zurn:sha1:3f30658830f3a133ba2136237ea9c8e589344a3b
Add new prog_tests directory where tests are supposed to land.
Each prog_tests/<filename>.c is expected to have a global function
with signature 'void test_<filename>(void)'. Makefile automatically
generates prog_tests/tests.h file with entry for each prog_tests file:
#ifdef DECLARE
extern void test_<filename>(void);
...
#endif
#ifdef CALL
test_<filename>();
...
#endif
prog_tests/tests.h is included in test_progs.c in two places with
appropriate defines. This scheme allows us to move each function with
a separate patch without breaking anything.
Compared to the recent verifier split, each separate file here is
a compilation unit and test_progs.[ch] is now used as a place to put
some common routines that might be used by multiple tests.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>