kernel/sound/soc/amd/acp, branch linux-6.2.y

ASoC: amd: acp: Fix possible UAF in acp_dma_open

2022-11-18T11:50:29Z

Smatch report warning as follows: sound/soc/amd/acp/acp-platform.c:199 acp_dma_open() warn: '&stream->list' not removed from list If snd_pcm_hw_constraint_integer() fails in acp_dma_open(), stream will be freed, but stream->list will not be removed from adata->stream_list, then list traversal may cause UAF. Fix by adding the newly allocated stream to the list once it's fully initialised. Fixes: 7929985cfe36 ("ASoC: amd: acp: Initialize list to store acp_stream during pcm_open") Signed-off-by: Gaosheng Cui Link: https://lore.kernel.org/r/20221118030056.3135960-1-cuigaosheng1@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: Add setbias level for rt5682s codec in machine driver

2022-10-19T14:14:00Z

Add set_bais_level function for rt5682s codec to enable bclk and lrclk before codec widgets power on and disable bclk and lrclk after widgets power down, to avoid pop noise Signed-off-by: Venkata Prasad Potturu Link: https://lore.kernel.org/r/20220921090750.3833256-1-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: Add TDM slots setting support for ACP I2S controller

2022-10-18T18:16:48Z

Modify set tdm slot function to set ACP I2S controller slots in tdm mode based on number of slots. Signed-off-by: Venkata Prasad Potturu Link: https://lore.kernel.org/r/20221018122711.2559452-1-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: use function devm_kcalloc() instead of devm_kzalloc()

2022-09-19T16:52:40Z

Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot Signed-off-by: ye xingchen Link: https://lore.kernel.org/r/20220916062027.152815-1-ye.xingchen@zte.com.cn Signed-off-by: Mark Brown

ASoC: amd: acp: use devm_kcalloc() instead of devm_kzalloc()

2022-09-19T16:52:37Z

Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot Signed-off-by: ye xingchen Link: https://lore.kernel.org/r/20220916061906.152434-1-ye.xingchen@zte.com.cn Signed-off-by: Mark Brown

ASoC: amd: acp: Modify dai_id macros to be more generic

2022-08-28T21:04:03Z

Change dai_id macros to make I2S instances in order. Signed-off-by: Venkata Prasad Potturu Link: https://lore.kernel.org/r/20220826064250.3302260-1-venkataprasad.potturu@amd.com Signed-off-by: Mark Brown

ASoC: amd: acp: remove unnecessary NULL checks

2022-08-19T12:20:00Z

The list iterator can never be NULL. Delete the bogus NULL checks. Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/Yv8ePUuBfzaRu6xV@kili Signed-off-by: Mark Brown

ASoC: amd: acp: add a label to make error path more clean

2022-08-19T12:19:58Z

Move platform_device_unregister() to a new label to make code more clean. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-3-yangyingliang@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: switch to use dev_err_probe()

2022-08-19T12:19:57Z

Use dev_err_probe() to simplify code and print error code. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-2-yangyingliang@huawei.com Signed-off-by: Mark Brown

ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe()

2022-08-19T12:19:56Z

Add missing platform_device_unregister() in error path in acp_pci_probe(). Fixes: c49f5e74a11e ("ASoC: amd: acp: Add error handling cases") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220819073758.1273160-1-yangyingliang@huawei.com Signed-off-by: Mark Brown