kernel/sound/pci/sonicvibes.c, branch 0x221E-v0.0.1-v6.19

ALSA: sonicvibes: Use guard() for spin locks

2025-09-01T11:52:42Z

Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20250829144342.4290-57-tiwai@suse.de

ALSA: sonicvibes: Use safer strscpy() instead of strcpy()

2025-07-11T07:53:34Z

Use a safer function strscpy() instead of strcpy() for copying to arrays. Only idiomatic code replacement, and no functional changes. Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20250710100727.22653-85-tiwai@suse.de

ALSA: sonicvibes: Use pure devres PCI

2025-04-24T07:21:33Z

pci_request_regions() is a hybrid function which becomes managed if pcim_enable_device() was called before. This hybrid nature is deprecated and should not be used anymore. Replace pci_request_regions() with the always-managed function pcim_request_all_regions(). Signed-off-by: Philipp Stanner Reviewed-by: Andy Shevchenko Signed-off-by: Takashi Iwai Link: https://patch.msgid.link/20250423075346.45907-2-phasta@kernel.org

ALSA: sonicvibes: Simplify with str_off_on()

2025-01-07T16:34:48Z

Use the standard helper str_off_on() to simplify the code. Only code refactoring, no behavior change. Link: https://patch.msgid.link/20250107155641.4435-3-tiwai@suse.de Signed-off-by: Takashi Iwai

ALSA: sonicvibes: Use str_on_off() helper in snd_sonicvibes_proc_read()

2024-12-11T13:24:32Z

Remove hard-coded strings by using the str_on_off() helper function. Signed-off-by: Thorsten Blum Link: https://patch.msgid.link/20241210172428.139643-2-thorsten.blum@linux.dev Signed-off-by: Takashi Iwai

ALSA: sonicvibes: Fix the missing snd_card_free() call at probe error

2022-04-12T15:58:33Z

The previous cleanup with devres may lead to the incorrect release orders at the probe error handling due to the devres's nature. Until we register the card, snd_card_free() has to be called at first for releasing the stuff properly when the driver tries to manage and release the stuff via card->private_free(). This patch fixes it by calling snd_card_free() on the error from the probe callback using a new helper function. Fixes: 2ca6cbde6ad7 ("ALSA: sonicvibes: Allocate resources with device-managed APIs") Cc: Link: https://lore.kernel.org/r/20220412102636.16000-25-tiwai@suse.de Signed-off-by: Takashi Iwai

ALSA: sonicvibes: Allocate resources with device-managed APIs

2021-07-19T14:16:49Z

This patch converts the resource management in PCI sonicvibes driver with devres as a clean up. Each manual resource management is converted with the corresponding devres helper, and the card object release is managed now via card->private_free instead of a lowlevel snd_device. This should give no user-visible functional changes. Link: https://lore.kernel.org/r/20210715075941.23332-25-tiwai@suse.de Signed-off-by: Takashi Iwai

ALSA: sonicvibes: Fix assignment in if condition

2021-06-09T15:30:01Z

PCI sonicvibes driver code contains a few assignments in if condition, which is a bad coding style that may confuse readers and occasionally lead to bugs. This patch is merely for coding-style fixes, no functional changes. Link: https://lore.kernel.org/r/20210608140540.17885-33-tiwai@suse.de Signed-off-by: Takashi Iwai

module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-17T20:16:18Z

MODULE_SUPPORTED_DEVICE was added in pre-git era and never was implemented. We can safely remove it, because the kernel has grown to have many more reliable mechanisms to determine if device is supported or not. Signed-off-by: Leon Romanovsky Signed-off-by: Linus Torvalds

ALSA: pci: Simplify with dma_set_mask_and_coherent()

2021-01-15T10:17:00Z

Many PCI drivers still have two explicit calls of dma_set_mask() and dma_set_coherent_mask(). Let's simplify with dma_set_mask_and_coherent(). Link: https://lore.kernel.org/r/20210114125412.993-2-tiwai@suse.de Signed-off-by: Takashi Iwai