kernel/sound/firewire/fireface/ff-transaction.c, branch linux-5.14.y

ALSA: fireface: Fix integer overflow in transmit_midi_msg()

2021-01-12T13:57:29Z

As snd_ff.rx_bytes[] is unsigned int, and NSEC_PER_SEC is 1000000000L, the second multiplication in ff->rx_bytes[port] * 8 * NSEC_PER_SEC / 31250 always overflows on 32-bit platforms, truncating the result. Fix this by precalculating "NSEC_PER_SEC / 31250", which is an integer constant. Note that this assumes ff->rx_bytes[port] <= 16777. Fixes: 19174295788de77d ("ALSA: fireface: add transaction support") Reviewed-by: Takashi Sakamoto Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20210111130251.361335-2-geert+renesas@glider.be Signed-off-by: Takashi Iwai

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345

2019-06-05T15:37:08Z

Based on 1 normalized pattern(s): licensed under the terms of the gnu general public license version 2 extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 88 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Alexios Zavras Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190530000437.521539229@linutronix.de Signed-off-by: Greg Kroah-Hartman

ALSA: fireface: comment cleanup about destination address of async transactions for MIDI messages

2019-01-24T13:39:32Z

In Fireface series, registration of higher 4 bytes of destination address for asynchronous transaction of MIDI messages is done by a write transaction to model-specific register. On the other hand, registration of lower 4 bytes of the address is selectable from 4 options. A register for this registration includes the other purpose options such as input attenuation. Thus this driver expects userspace applications to configure the register. Actual behaviour for the asynchronous transaction is different depending on protocols. In former protocol, destination offset of each transaction is the same as the registered address even if it is block request. In latter models, destination offset of each transaction is the offset of previous transaction plus 4 byte and the transaction is quadlet request. This commit cleanups comments about the above mechanism. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: add protocol-specific operation to fill transaction buffer with MIDI messages

2019-01-22T16:20:54Z

Between former and latter models, content of asynchronous transaction for MIDI messages from driver to device is different. This commit is a preparation to support latter models. A protocol-specific operation is added to encode MIDI messages to the transaction. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: add model-dependent parameter for address to receive async transaction for MIDI messages

2019-01-22T16:20:53Z

Between former and latter models, destination address to receive asynchronous transactions for MIDI messages is different. This commit adds model-dependent parameter for the addresses. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: add model-dependent parameter for address range to receive async transaction

2019-01-22T16:20:50Z

In Fireface series, drivers can register destination address for asynchronous transaction which transfers MIDI messages from device. In former models, all of the transactions arrive at the registered address without any offset. In latter models, each of the transaction arrives at the registered address with sequential offset within 0x00 to 0x7f. This seems to be for discontinuity detection. This commit adds model-dependent member for the address range. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: change prototype of handler for async transaction with MIDI messages

2019-01-22T16:20:49Z

In a series of Fireface, devices transfer asynchronous transaction with MIDI messages. In the transaction, content is different depending on models. ALSA fireface driver has protocol-dependent handler to pick up MIDI messages from the content. In latter models of the series, the transaction is transferred to range of address sequentially. This seems to check continuity of transferred messages. This commit changes prototype of the handler to receive offset of address for received transactions. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: add protocol-dependent operation to get clock status

2019-01-21T14:12:20Z

This commit adds a member for a callback function to get clock status to former protocol. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: code refactoring to handle model-specific registers

2018-12-16T09:18:31Z

As a result of investigation for Fireface 800, 'struct snd_ff_spec.regs' is just for higher address to receive tx asynchronous packets of MIDI messages, thus it can be simplified. This commit simplifies it. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireface: localize a handler for MIDI messages on tx transaction

2018-12-11T13:57:38Z

Content of asynchronous transaction for MIDI messages differs between Fireface 400 and 800. This commit adds a model-specific handler for the transaction and adds arrangement. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai