kernel/net/openvswitch, branch linux-3.4.y

net: make skb_gso_segment error handling more robust

2015-06-19T03:40:33Z

commit 330966e501ffe282d7184fde4518d5e0c24bc7f8 upstream. skb_gso_segment has three possible return values: 1. a pointer to the first segmented skb 2. an errno value (IS_ERR()) 3. NULL. This can happen when GSO is used for header verification. However, several callers currently test IS_ERR instead of IS_ERR_OR_NULL and would oops when NULL is returned. Note that these call sites should never actually see such a NULL return value; all callers mask out the GSO bits in the feature argument. However, there have been issues with some protocol handlers erronously not respecting the specified feature mask in some cases. It is preferable to get 'have to turn off hw offloading, else slow' reports rather than 'kernel crashes'. Signed-off-by: Florian Westphal Signed-off-by: David S. Miller Cc: Ben Hutchings [lizf: Backported to 3.4: drop some hunks as there are fewer skb_gso_segment() users in 3.4] Signed-off-by: Zefan Li

openvswitch: Check currect return value from skb_gso_segment()

2015-06-19T03:40:33Z

commit 92e5dfc34cf39c20ae1087bd5e676238b5d0dfac upstream. Fix return check typo. Signed-off-by: Pravin B Shelar Signed-off-by: Jesse Gross Signed-off-by: Zefan Li

openvswitch: Reset upper layer protocol info on internal devices.

2012-10-02T17:29:50Z

[ Upstream commit 7fe99e2d434eafeac0c57b279a77e5de39212636 ] It's possible that packets that are sent on internal devices (from the OVS perspective) have already traversed the local IP stack. After they go through the internal device, they will again travel through the IP stack which may get confused by the presence of existing information in the skb. The problem can be observed when switching between namespaces. This clears out that information to avoid problems but deliberately leaves other metadata alone. This is to provide maximum flexibility in chaining together OVS and other Linux components. Signed-off-by: Jesse Gross Signed-off-by: Greg Kroah-Hartman

openvswitch: checking wrong variable in queue_userspace_packet()

2012-05-13T19:47:34Z

"skb" is non-NULL here, for example we dereference it in skb_clone(). The intent was to test "nskb" which was just set. Signed-off-by: Dan Carpenter Acked-by: Jesse Gross Signed-off-by: David S. Miller

openvswitch: Validation of IPv6 set port action uses IPv4 header

2012-05-08T00:23:10Z

When the kernel validates set TCP/UDP port actions, it looks at the ports in the existing flow to make sure that the L4 header exists. However, these actions always use the IPv4 version of the struct. Following patch fixes this by checking for flow ip protocol first. Signed-off-by: Pravin B Shelar Signed-off-by: Jesse Gross

openvswitch: Release rtnl_lock if ovs_vport_cmd_build_info() failed.

2012-05-04T01:40:38Z

This patch fixes a possible lock-up bug where rtnl_lock might not get released. Signed-off-by: Ansis Atteka Signed-off-by: Jesse Gross

openvswitch: Add length check when retrieving TCP flags.

2012-04-02T21:28:57Z

When collecting TCP flags we check that the IP header indicates that a TCP header is present but not that the packet is actually long enough to contain the header. This adds a check to prevent reading off the end of the packet. In practice, this is only likely to result in reading of bad data and not a crash due to the presence of struct skb_shared_info at the end of the packet. Signed-off-by: Jesse Gross

Remove all #inclusions of asm/system.h

2012-03-28T17:30:03Z

Remove all #inclusions of asm/system.h preparatory to splitting and killing it. Performed with the following command: perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *` Signed-off-by: David Howells

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-03-09T22:34:20Z

openvswitch: Fix checksum update for actions on UDP packets.

2012-03-07T22:36:57Z

When modifying IP addresses or ports on a UDP packet we don't correctly follow the rules for unchecksummed packets. This meant that packets without a checksum can be given a incorrect new checksum and packets with a checksum can become marked as being unchecksummed. This fixes it to handle those requirements. Signed-off-by: Jesse Gross