kernel/net/nfc/core.c, branch linux-5.1.y

NFC: Convert timers to use timer_setup()

2017-11-06T00:12:10Z

Switch to using the new timer_setup() and from_timer() for net/nfc/* Signed-off-by: Allen Pais Reviewed-by: Kees Cook Signed-off-by: Samuel Ortiz

NFC: fix device-allocation error return

2017-11-05T23:53:39Z

A recent change fixing NFC device allocation itself introduced an error-handling bug by returning an error pointer in case device-id allocation failed. This is clearly broken as the callers still expected NULL to be returned on errors as detected by Dan's static checker. Fix this up by returning NULL in the event that we've run out of memory when allocating a new device id. Note that the offending commit is marked for stable (3.8) so this fix needs to be backported along with it. Fixes: 20777bc57c34 ("NFC: fix broken device allocation") Cc: stable # 3.8 Reported-by: Dan Carpenter Signed-off-by: Johan Hovold Signed-off-by: Samuel Ortiz

net:nfc: use setup_timer

2017-09-21T22:47:57Z

Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais Signed-off-by: David S. Miller

NFC: fix broken device allocation

2017-06-18T21:57:58Z

Commit 7eda8b8e9677 ("NFC: Use IDR library to assing NFC devices IDs") moved device-id allocation and struct-device initialisation from nfc_allocate_device() to nfc_register_device(). This broke just about every nfc-device-registration error path, which continue to call nfc_free_device() that tries to put the device reference of the now uninitialised (but zeroed) struct device: kobject: '(null)' (ce316420): is not initialized, yet kobject_put() is being called. The late struct-device initialisation also meant that various work queues whose names are derived from the nfc device name were also misnamed: 421 root 0 SW< [(null)_nci_cmd_] 422 root 0 SW< [(null)_nci_rx_w] 423 root 0 SW< [(null)_nci_tx_w] Move the id-allocation and struct-device initialisation back to nfc_allocate_device() and fix up the single call site which did not use nfc_free_device() in its error path. Fixes: 7eda8b8e9677 ("NFC: Use IDR library to assing NFC devices IDs") Cc: stable # 3.8 Cc: Samuel Ortiz Signed-off-by: Johan Hovold Signed-off-by: Samuel Ortiz

nfc: netlink: HCI event connectivity implementation

2015-12-29T18:06:20Z

Add support for missing HCI event EVT_CONNECTIVITY and forward it to userspace. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: netlink: Add mode parameter to deactivate_target functions

2015-10-27T02:55:12Z

In order to manage in a better way the nci poll mode state machine, add mode parameter to deactivate_target functions. This way we can manage different target state. mode parameter make sense only in nci core. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: Forward NFC_EVT_TRANSACTION to user space

2015-02-02T20:50:40Z

NFC_EVT_TRANSACTION is sent through netlink in order for a specific application running on a secure element to notify userspace of an event. Typically the secure element application counterpart on the host could interpret that event and act upon it. Forwarded information contains: - SE host generating the event - Application IDentifier doing the operation - Applications parameters Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: nfc_disable_se Remove useless blank line at beginning of function

2015-01-26T22:14:33Z

Remove one useless blank line at beginning of nfc_disable_se function. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: nfc_enable_se Remove useless blank line at beginning of function

2015-01-26T22:14:33Z

Remove one useless blank line at beginning of nfc_enable_se function. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: Move checking valid gb_len value to nfc_llcp_set_remote_gb

2014-03-14T19:19:08Z

This checking is common for all caller, so move the checking to one place. Signed-off-by: Axel Lin Signed-off-by: Samuel Ortiz