kernel/net/hsr, branch linux-4.3.y

net: hsr: convert to using IFF_NO_QUEUE

2015-08-18T18:55:07Z

Signed-off-by: Phil Sutter Cc: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Fix NULL pointer dereference and refcnt bugs when deleting a HSR interface.

2015-03-01T18:40:23Z

To repeat: $ sudo ip link del hsr0 BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 IP: [] hsr_del_port+0x15/0xa0 etc... Bug description: As part of the hsr master device destruction, hsr_del_port() is called for each of the hsr ports. At each such call, the master device is updated regarding features and mtu. When the master device is freed before the slave interfaces, master will be NULL in hsr_del_port(), which led to a NULL pointer dereference. Additionally, dev_put() was called on the master device itself in hsr_del_port(), causing a refcnt error. A third bug in the same code path was that the rtnl lock was not taken before hsr_del_port() was called as part of hsr_dev_destroy(). The reporter (Nicolas Dichtel) also said: "hsr_netdev_notify() supposes that the port will always be available when the notification is for an hsr interface. It's wrong. For example, netdev_wait_allrefs() may resend NETDEV_UNREGISTER.". As a precaution against this, a check for port == NULL was added in hsr_dev_notify(). Reported-by: Nicolas Dichtel Fixes: 51f3c605318b056a ("net/hsr: Move slave init to hsr_slave.c.") Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Remove left-over never-true conditional code.

2014-07-11T22:04:40Z

MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated as a part of *node_dst (which is a struct hsr_node). So the condition is always false. Detected by Dan Carpenter. Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Fix NULL pointer dereference on incomplete hsr_newlink() params.

2014-07-08T18:35:31Z

If none of the slave interfaces are specified, struct nlattr *data[] may be NULL. Make sure to check for that. While I'm at it, fix the horrible error messages displayed when only one of the slave interfaces isn't specified. Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Better frame dispatch

2014-07-08T18:35:31Z

This patch removes the separate paths for frames coming from the outside, and frames sent from the HSR device, and instead makes all frames go through hsr_forward_skb() in hsr_forward.c. This greatly improves code readability and also opens up the possibility for future support of the HSR Interlink device that is the basis for HSR RedBoxes and HSR QuadBoxes, as well as VLAN compatibility. Other improvements: * A reduction in the number of times an skb is copied on machines without HAVE_EFFICIENT_UNALIGNED_ACCESS, which improves throughput somewhat. * Headers are now created using the standard eth_header(), and using the standard hard_header_len. * Each HSR slave now gets its own private skb, so slave-specific fields can be correctly set. Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Added SET_NETDEV_DEVTYPE and features |= NETIF_F_NETNS_LOCAL to dev_setup.

2014-07-08T18:35:31Z

Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Implemented .ndo_fix_features (better device features handling).

2014-07-08T18:35:31Z

Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Use list_head (and rcu) instead of array for slave devices.

2014-07-08T18:35:31Z

Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Move slave init to hsr_slave.c.

2014-07-08T18:35:31Z

Also try to prevent some possible slave dereference race conditions. This is finalized in the next patch, which abandons the slave array in favour of a list_head list and list RCU. Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller

net/hsr: Operstate handling cleanup.

2014-07-08T18:35:30Z

Signed-off-by: Arvid Brodin Signed-off-by: David S. Miller