kernel/include/linux/sunrpc/xdr.h, branch linux-5.10.y

NFSD: Refactor common code out of dirlist helpers

2024-06-21T12:54:00Z

[ Upstream commit 98124f5bd6c76699d514fbe491dd95265369cc99 ] The dust has settled a bit and it's become obvious what code is totally common between nfsd_init_dirlist_pages() and nfsd3_init_dirlist_pages(). Move that common code to SUNRPC. The new helper brackets the existing xdr_init_decode_pages() API. Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Fix xdr_encode_bool()

2024-06-21T12:53:47Z

[ Upstream commit c770f31d8f580ed4b965c64f924ec1cc50e41734 ] I discovered that xdr_encode_bool() was returning the same address that was passed in the @p parameter. The documenting comment states that the intent is to return the address of the next buffer location, just like the other "xdr_encode_*" helpers. The result was the encoded results of NFSv3 PATHCONF operations were not formed correctly. Fixes: ded04a587f6c ("NFSD: Update the NFSv3 PATHCONF3res encoder to use struct xdr_stream") Signed-off-by: Chuck Lever Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Optimize xdr_reserve_space()

2024-06-21T12:53:45Z

[ Upstream commit 62ed448cc53b654036f7d7f3c99f299d79ad14c3 ] Transitioning between encode buffers is quite infrequent. It happens about 1 time in 400 calls to xdr_reserve_space(), measured on NFSD with a typical build/test workload. Force the compiler to remove that code from xdr_reserve_space(), which is a hot path on both the server and the client. This change reduces the size of xdr_reserve_space() from 10 cache lines to 2 when compiled with -Os. Signed-off-by: Chuck Lever Reviewed-by: J. Bruce Fields Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

NFSD: Update the NFSv3 PATHCONF3res encoder to use struct xdr_stream

2024-06-21T12:53:00Z

[ Upstream commit ded04a587f6ceaaba3caefad4021f2212b46c9ff ] Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

NFSD: Update the NFSv3 READ3res encode to use struct xdr_stream

2024-06-21T12:53:00Z

[ Upstream commit cc9bcdad7773c295375e66c892c7ac00524706f2 ] Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Move definition of XDR_UNIT

2024-06-21T12:52:50Z

[ Upstream commit 81d217474326b25d7f14274b02fe3da1e85ad934 ] Clean up: The unit of XDR alignment is defined by RFC 4506, not as part of the RPC message header. Thus it belongs in include/linux/sunrpc/xdr.h. Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

NFSD: Add helper for decoding locker4

2024-06-21T12:52:37Z

[ Upstream commit 8918cc0d2b72db9997390626010b182c4500d749 ] Refactor for clarity. Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

NFSD: Replace READ* macros in nfsd4_decode_commit()

2024-06-21T12:52:35Z

[ Upstream commit cbd9abb3706e96563b36af67595707a7054ab693 ] Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

NFSD: Replace the internals of the READ_BUF() macro

2024-06-21T12:52:34Z

[ Upstream commit c1346a1216ab5cb04a265380ac9035d91b16b6d5 ] Convert the READ_BUF macro in nfs4xdr.c from open code to instead use the new xdr_stream-style decoders already in use by the encode side (and by the in-kernel NFS client implementation). Once this conversion is done, each individual NFSv4 argument decoder can be independently cleaned up to replace these macros with C code. Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Add xdr_set_scratch_page() and xdr_reset_scratch_buffer()

2024-06-21T12:52:33Z

[ Upstream commit 0ae4c3e8a64ace1b8d7de033b0751afe43024416 ] Clean up: De-duplicate some frequently-used code. Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin