kernel/include/linux/nvme-tcp.h, branch linux-6.3.y

nvme-tcp: fix nvme_tcp_term_pdu to match spec

2023-03-22T08:19:56Z

The FEI field of C2HTermReq/H2CTermReq is 4 bytes but not 4-byte-aligned in the NVMe/TCP specification (it is located at offset 10 in the PDU). Split it into two 16-bit integers in struct nvme_tcp_term_pdu so no padding is inserted. There should also be 10 reserved bytes after. There are currently no users of this type. Fixes: fc221d05447aa6db ("nvme-tcp: Add protocol header") Reported-by: Geert Uytterhoeven Signed-off-by: Caleb Sander Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig

nvme-tcp: send H2CData PDUs based on MAXH2CDATA

2022-02-23T13:43:11Z

As per NVMe/TCP specification (revision 1.0a, section 3.6.2.3) Maximum Host to Controller Data length (MAXH2CDATA): Specifies the maximum number of PDU-Data bytes per H2CData PDU in bytes. This value is a multiple of dwords and should be no less than 4,096. Current code sets H2CData PDU data_length to r2t_length, it does not check MAXH2CDATA value. Fix this by setting H2CData PDU data_length to min(req->h2cdata_left, queue->maxh2cdata). Also validate MAXH2CDATA value returned by target in ICResp PDU, if it is not a multiple of dword or if it is less than 4096 return -EINVAL from nvme_tcp_init_connection(). Signed-off-by: Varun Prakash Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig

nvme-tcp.h: fix SPDX header

2019-02-20T14:22:10Z

For .h files we need to use /* */ style comments. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg

nvme-tcp: Add protocol header

2018-12-13T08:58:57Z

Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig