kernel/fs/udf/file.c, branch linux-5.1.y

udf: Apply uid/gid mount options also to new inodes & chown

2018-02-27T09:25:33Z

Currently newly created files belong to current user despite uid= / gid= mount options. This is confusing to users (as owner of the file will change after remount / eviction from cache) and also inconsistent with e.g. FAT with the same mount option. So apply uid= and gid= also to newly created inodes and similarly as FAT disallow to change owner of the file in this case. Reported-by: Steve Kenton Reviewed-by: Pali Rohár Signed-off-by: Jan Kara

udf: Use i_size_read() in udf_adinicb_writepage()

2017-06-14T09:21:01Z

We don't hold inode_lock in udf_adinicb_writepage() so use i_size_read() to get i_size. This cannot cause real problems is i_size is guaranteed to be small but let's be careful. Signed-off-by: Jan Kara

udf: Fix races with i_size changes during readpage

2017-06-14T09:21:01Z

__udf_adinicb_readpage() uses i_size several times. When truncate changes i_size while the function is running, it can observe several different values and thus e.g. expose uninitialized parts of page to userspace. Also use i_size_read() in the function since it does not hold inode_lock. Since i_size is guaranteed to be small, this cannot really cause any issues even on 32-bit archs but let's be careful. CC: stable@vger.kernel.org Fixes: 9c2fc0de1a6e638fe58c354a463f544f42a90a09 Signed-off-by: Jan Kara

udf: use kmap_atomic for memcpy copying

2017-04-24T14:28:02Z

Use temporary mapping for memory copying operations. To avoid any sleeping problem, mark_inode_dirty(inode) was moved after kunmap() in udf_adinicb_readpage() down_write(&iinfo->i_data_sem) set before kmap_atomic() in udf_expand_file_adinicb() Signed-off-by: Fabian Frederick Signed-off-by: Jan Kara

udf: simplify udf_ioctl()

2017-02-03T15:24:18Z

"out" label was only returning error code. Signed-off-by: Fabian Frederick Signed-off-by: Jan Kara

udf: fix ioctl errors

2017-02-03T15:19:54Z

Currently, lsattr for instance in udf directory gives "udf: Invalid argument While reading flags on ..." This patch returns -ENOIOCTLCMD when command is unknown to have more accurate message like this: "Inappropriate ioctl for device While reading flags on ..." Signed-off-by: Fabian Frederick Signed-off-by: Jan Kara

fs: Give dentry to inode_change_ok() instead of inode

2016-09-22T08:56:19Z

inode_change_ok() will be resposible for clearing capabilities and IMA extended attributes and as such will need dentry. Give it as an argument to inode_change_ok() instead of an inode. Also rename inode_change_ok() to setattr_prepare() to better relect that it does also some modifications in addition to checks. Reviewed-by: Christoph Hellwig Signed-off-by: Jan Kara

udf: don't bother with full-page write optimisations in adinicb case

2016-09-19T08:47:01Z

... it would get converted to regular if such had been attempted Signed-off-by: Al Viro Signed-off-by: Jan Kara

udf: Remove useless check in udf_adinicb_write_begin()

2016-09-06T16:04:40Z

As Al properly points out, len is guaranteed to be smaller than PAGE_SIZE when we reach udf_adinicb_write_begin() as otherwise we would have converted the file to the normal format. Reported-by: Al Viro Signed-off-by: Jan Kara

fs: simplify the generic_write_sync prototype

2016-05-01T23:58:39Z

The kiocb already has the new position, so use that. The only interesting case is AIO, where we currently don't bother updating ki_pos. We're about to free the kiocb after we're done, so we might as well update it to make everyone's life simpler. While we're at it also return the bytes written argument passed in if we were successful so that the boilerplate error switch code in the callers can go away. Signed-off-by: Christoph Hellwig Signed-off-by: Al Viro