kernel/drivers/video/fbdev/sm501fb.c, branch linux-5.1.y

video: sm501fb: Improve a size determination in sm501fb_probe()

2018-04-26T10:24:18Z

Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Cc: Alexey Khoroshilov Cc: Bhumika Goyal Cc: Colin Ian King Cc: "Gustavo A. R. Silva" Cc: Sudip Mukherjee Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: sm501fb: fix potential null pointer dereference on fbi

2017-11-17T16:21:48Z

The pointer fbi is dereferenced with par = fbi->par before there is a null check on fbi, hence there is a potential null pointer dereference on a null par. Fix this by moving the dereference after the null pointer check. Detected by CoverityScan, CID#1461301 ("Dereference before null check") Signed-off-by: Colin Ian King Cc: Sudip Mukherjee Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt

2017-11-09T17:09:32Z

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Bartlomiej Zolnierkiewicz

sm501fb: suspend and resume fb if it exists

2017-11-09T17:09:31Z

There are cases when panel and crt both are not defined and only one of them is defined and initialized. In such cases, suspend or resume it only if it is defined. Signed-off-by: Sudip Mukherjee Signed-off-by: Bartlomiej Zolnierkiewicz

sm501fb: unregister framebuffer only if registered

2017-11-09T17:09:31Z

There are cases when panel and crt both are not defined and only one of them is defined and initialized. In such cases, while removing the device, unregister the framebuffer only if it was registered. Signed-off-by: Sudip Mukherjee Signed-off-by: Bartlomiej Zolnierkiewicz

sm501fb: deallocate colormap only if allocated

2017-11-09T17:09:31Z

There are cases when panel and crt both are not defined and only one of them is defined and initialized. In such cases, while removing the device deallocate the colormap only if that particular fb is defined. Signed-off-by: Sudip Mukherjee Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: make fb_videomode const

2017-09-04T14:00:49Z

Make these const as they are only passed to a const argument of the function fb_find_mode. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct fb_videomode s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ identifier match.s; expression list[5] es; position ref.p; @@ fb_find_mode(es,&s@p,...) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct fb_videomode s; Signed-off-by: Bhumika Goyal Cc: Julia Lawall Cc: Paul Mackerras Cc: Russell King Signed-off-by: Bartlomiej Zolnierkiewicz

sm501fb: don't return zero on failure path in sm501fb_start()

2017-05-02T11:47:53Z

If fbmem iomemory mapping failed, sm501fb_start() breaks off initialization, deallocates resources, but returns zero. As a result, double deallocation can happen in sm501fb_stop(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Cc: Tomi Valkeinen Signed-off-by: Bartlomiej Zolnierkiewicz

Replace with globally

2016-12-24T19:46:01Z

This was entirely automated, using the script by Al: PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*' sed -i -e "s!$PATT!#include !" \ $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h) to do the replacement at the end of the merge window. Requested-by: Al Viro Signed-off-by: Linus Torvalds

fbdev: sm501fb: use memset_io

2015-03-02T11:17:24Z

we should really be using memset_io() instead of using memset() as this is actually io space mapped into our memory. Signed-off-by: Sudip Mukherjee Signed-off-by: Tomi Valkeinen