kernel/drivers/video/fbdev/imxfb.c, branch linux-6.9.yHosts the 0x221E linux distro kernel.https://universe.0xinfinity.dev/distro/kernel/atom?h=linux-6.9.y2024-01-11T16:09:01Zfbdev: imxfb: add '*/' on a separate line in block comment2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:59Zurn:sha1:d6dfcdaa4e6e1a7fa99dc068f47f6b7b8c5bb634
Linux kernel coding style uses '*/' on a separate line at the end of
multi line comments.
Fix block comments by moving '*/' at the end of block comments on a
separate line as reported by checkpatch:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: use __func__ for function name2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:58Zurn:sha1:cb892e5dfed3044974c4f10addbc297966224fe8
Resolve the following warning reported by checkpatch:
WARNING: Prefer using '"%s...", __func__' to using 'imxfb_blank', this function's name, in a string
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: Fix style warnings relating to printk()2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:57Zurn:sha1:77bf5df43348c45eddf40e06e9a1d417f1d755ef
Resolve the following warning reported by checkpatch:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
This made it necessary to move the 'fbi->pdev = pdev' setting to the
beginning of the driver's probing.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing spaces after ','2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:56Zurn:sha1:62c82a47cbf8f183db24382bd5fc6e3067cd54c4
Fix the following checkpatch error:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: drop ftrace-like logging2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:55Zurn:sha1:f11025059b59fe84880b48b2c3e7cf6894677b93
Resolve the following warning reported by checkpatch:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing SPDX tag2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:54Zurn:sha1:df937b8bb6044f1763945e00a5c0b29b8cc51ba4
Resolve the following warning reported by checkpatch.pl:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
The patch also removes some license info made redundant by the addition
of the SPDX tag.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: replace some magic numbers with constants2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:53Zurn:sha1:da119a074d776e95a29d5891cf50248553064749
The patch gets rid of magic numbers replacing them with appropriate
macros.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: use BIT, FIELD_{GET,PREP} and GENMASK macros2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:52Zurn:sha1:b0e05872f7ae4d005e51952b2f3aca9504452495
Replace opencoded masking and shifting, with BIT(), GENMASK(),
FIELD_GET() and FIELD_PREP() macros.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: move PCR bitfields near their offset2024-01-11T16:09:01ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:51Zurn:sha1:b85f173679900d1f4d1abfc6aa00495ecf1b17e4
The patch moves the bitfields of the PCR register near the macro that
defines its offset, just like for all the other registers.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: fix left margin setting2024-01-11T16:09:00ZDario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:50Zurn:sha1:5758844105f7dd9a0a04990cd92499a1a593dd36
The previous setting did not take into account the CSTN mode.
For the H_WAIT_2 bitfield (bits 0-7) of the LCDC Horizontal Configuration
Register (LCDCR), the IMX25RM manual states that:
In TFT mode, it specifies the number of SCLK periods between the end of
HSYNC and the beginning of OE signal, and the total delay time equals
(H_WAIT_2 + 3) of SCLK periods.
In CSTN mode, it specifies the number of SCLK periods between the end of
HSYNC and the first display data in each line, and the total delay time
equals (H_WAIT_2 + 2) of SCLK periods.
The patch handles both cases.
Fixes: 4e47382fbca9 ("fbdev: imxfb: warn about invalid left/right margin")
Fixes: 7e8549bcee00 ("imxfb: Fix margin settings")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>