kernel/drivers/usb/serial/sierra.c, branch linux-6.18.y

drivers/usb/serial: refactor min with min_t

2024-11-13T14:09:51Z

Ensure type safety by using min_t() instead of casted min(). Signed-off-by: Sabyrzhan Tasbolatov Link: https://lore.kernel.org/r/20241112155817.3512577-8-snovitoll@gmail.com Signed-off-by: Greg Kroah-Hartman

USB: serial: drop driver owner initialization

2024-08-26T13:28:25Z

Core in usb_serial_register_drivers() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold

USB: serial: fix tty-port initialized comments

2022-07-25T09:01:40Z

Fix up the tty-port initialized comments which got truncated and obfuscated when replacing the old ASYNCB_INITIALIZED flag. Fixes: d41861ca19c9 ("tty: Replace ASYNC_INITIALIZED bit and update atomically") Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: use kmemdup instead of kmalloc + memcpy

2022-06-22T06:56:52Z

For code neat purpose, we can use kmemdup to replace kmalloc + memcpy. Signed-off-by: Slark Xiao Signed-off-by: Johan Hovold

USB: serial: replace symbolic permissions by octal permissions

2021-08-26T07:38:27Z

Replace symbolic permission macros with octal permission numbers because octal permission numbers are easier to read and understand instead of their symbolic macro names. No functional change. Suggested-by: Lukas Bulwahn Signed-off-by: Utkarsh Verma Signed-off-by: Johan Hovold

USB: serial: make usb_serial_driver::chars_in_buffer return uint

2021-05-19T08:56:41Z

tty_operations::chars_in_buffer is being switched to return uint. Do the same for usb_serial_driver's chars_in_buffer. Signed-off-by: Jiri Slaby [ johan: amend commit message ] Signed-off-by: Johan Hovold

USB: serial: make usb_serial_driver::write_room return uint

2021-05-19T08:56:40Z

Line disciplines expect a positive value or zero returned from tty->ops->write_room (invoked by tty_write_room). Both of them are being updated to return an unsigned int. Switch also usb_serial_driver::write_room and all its users. Signed-off-by: Jiri Slaby [ johan: amend commit message, drop unrelated comment change ] Signed-off-by: Johan Hovold

USB: serial: make remove callback return void

2021-02-09T12:13:58Z

All usb_serial drivers return 0 in their remove callbacks and driver core ignores the value returned by usb_serial_device_remove(). So change the remove callback to return void and return 0 unconditionally in usb_serial_device_remove(). Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20210208143149.963644-2-uwe@kleine-koenig.org Signed-off-by: Johan Hovold

USB: serial: sierra: clean up special-interface handling

2020-07-14T09:50:57Z

Clean up the handling of special interfaces that either should be ignored or that need a larger number of URBs. Commit 66f092ed3b94 ("USB: serial: sierra: unify quirk handling logic") replaced the previous is_blacklisted() and is_highmemory() helpers with a single is_quirk() helper which made it even harder to understand what the interface lists were used for. Rename the interface-list struct, its members and the interface-lookup helper and restructure the code somewhat in order to make it more self-explanatory. Link: https://lore.kernel.org/r/20200713153936.18032-1-johan@kernel.org Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: drop redundant transfer-buffer casts

2020-07-09T07:20:17Z

Drop redundant URB transfer-buffer casts. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold