kernel/drivers/usb/host/xen-hcd.c, branch linux-6.9.y

xen: make remove callback of xen driver void returned

2022-12-15T15:06:10Z

Since commit fc7a6209d571 ("bus: Make remove callback return void") forces bus_type::remove be void-returned, it doesn't make much sense for any bus based driver implementing remove callbalk to return non-void to its caller. This change is for xen bus based drivers. Acked-by: Juergen Gross Signed-off-by: Dawei Li Link: https://lore.kernel.org/r/TYCP286MB23238119AB4DF190997075C9CAE39@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM Signed-off-by: Juergen Gross

xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-19T12:22:05Z

Simplify xen-hcd's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman Signed-off-by: Juergen Gross

xen/usb: switch xen-hcd to use INVALID_GRANT_REF

2022-05-19T12:21:43Z

Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman Signed-off-by: Juergen Gross

Merge tag 'for-linus-5.18-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip

2022-03-28T21:32:39Z

Pull xen updates from Juergen Gross: - A bunch of minor cleanups - A fix for kexec in Xen dom0 when executed on a high cpu number - A fix for resuming after suspend of a Xen guest with assigned PCI devices - A fix for a crash due to not disabled preemption when resuming as Xen dom0 * tag 'for-linus-5.18-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip: xen: fix is_xen_pmu() xen: don't hang when resuming PCI device arch:x86:xen: Remove unnecessary assignment in xen_apic_read() xen/grant-table: remove readonly parameter from functions xen/grant-table: remove gnttab_*transfer*() functions drivers/xen: use helper macro __ATTR_RW x86/xen: Fix kerneldoc warning xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32 xen: use time_is_before_eq_jiffies() instead of open coding it

xen/usb: harden xen_hcd against malicious backends

2022-03-16T08:05:59Z

Make sure a malicious backend can't cause any harm other than wrong I/O data. Missing are verification of the request id in a response, sanitizing the reported actual I/O length, and protection against interrupt storms from the backend. Signed-off-by: Juergen Gross Link: https://lore.kernel.org/r/20220311103509.12908-1-jgross@suse.com Signed-off-by: Greg Kroah-Hartman

Merge tag 'v5.17-rc8' into usb-next

2022-03-16T08:04:22Z

We need the Xen USB fixes as other patches depend on those changes. Signed-off-by: Greg Kroah-Hartman

xen/grant-table: remove readonly parameter from functions

2022-03-16T01:34:40Z

The gnttab_end_foreign_access() family of functions is taking a "readonly" parameter, which isn't used. Remove it from the function parameters. Signed-off-by: Juergen Gross Link: https://lore.kernel.org/r/20220311103429.12845-3-jgross@suse.com Reviewed-by: Jan Beulich Acked-by: Christian Schoenebeck Signed-off-by: Boris Ostrovsky

xen/usb: don't use arbitrary_virt_to_machine()

2022-03-15T17:39:07Z

arbitrary_virt_to_machine() is meant to be used in PV guests only. Replace its usage with virt_to_gfn(). Signed-off-by: Juergen Gross Link: https://lore.kernel.org/r/20220311103500.12885-1-jgross@suse.com Signed-off-by: Greg Kroah-Hartman

xen/usb: don't use gnttab_end_foreign_access() in xenhcd_gnttab_done()

2022-03-07T08:48:55Z

The usage of gnttab_end_foreign_access() in xenhcd_gnttab_done() is not safe against a malicious backend, as the backend could keep the I/O page mapped and modify it even after the granted memory page is being used for completely other purposes in the local system. So replace that use case with gnttab_try_end_foreign_access() and disable the PV host adapter in case the backend didn't stop using the granted page. In xenhcd_urb_request_done() immediately return in case of setting the device state to "error" instead of looking into further backend responses. Reported-by: Demi Marie Obenour Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - use gnttab_try_end_foreign_access()

usb: host: xen-hcd: add missing unlock in error path

2021-12-15T22:48:29Z

Add the missing unlock before return from function xenhcd_urb_request_done() and xenhcd_conn_notify() in the error handling case. Fixes: 494ed3997d75 ("usb: Introduce Xen pvUSB frontend (xen hcd)") Reported-by: Hulk Robot Reviewed-by: Juergen Gross Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20211215035805.375244-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman