kernel/drivers/tty/serial/xilinx_uartps.c, branch linux-4.1.y

serial: xilinx: Use platform_get_irq to get irq description structure

2015-04-28T12:26:21Z

For systems with CONFIG_SERIAL_OF_PLATFORM=y and device_type = "serial"; property in DT of_serial.c driver maps and unmaps IRQ (because driver probe fails). Then a driver is called but irq mapping is not created that's why driver is failing again in again on request_irq(). Based on this use platform_get_irq() instead of platform_get_resource() which is doing irq_desc allocation and driver itself can request IRQ. Fix both xilinx serial drivers in the tree. Signed-off-by: Michal Simek CC: Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix check in console_setup().

2015-03-26T21:55:18Z

cdns_uart_console_setup() checks port->mapbase != 0, but the port may not be initialized yet even if this condition is met [e.g., ioremap() may have failed]. Check port->membase != NULL instead, similar to cdns_early_console_setup(). Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Get rid of register access macros.

2015-03-26T21:54:07Z

Get rid of cdns_uart_readl() and cdns_uart_writel() and just call readl() and writel() directly. Most of the patch was created by search-and-replace (I had to convert a few lines manually, and break some lines longer than 80 columns): * s/cdns_uart_readl(/readl(port->membase + /g * s/cdns_uart_writel(\([^,]*\),/writel(\1, port->membase +/g Signed-off-by: Thomas Betker Acked-by: Sören Brinkmann Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix iobase use.

2015-03-26T21:52:30Z

cdns_uart_get_port() sets port->iobase = 1 to "mark port in use", but this "in use" condition is not checked anywhere else in the code. So remove the line, keeping port->iobase = 0 (which also makes more sense). Signed-off-by: Thomas Betker Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix cdns_uart_port[] definition.

2015-03-26T21:52:29Z

The code assumes that the array cdns_uart_port[] has dimension CDNS_UART_NR_PORTS, so let us define it this way. Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix register space size.

2015-03-26T21:52:29Z

The register space size is 0x1000, and this value [not 0xfff] should be provided to request_mem_region(), ioremap(), etc. Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

tty: constify of_device_id array

2015-03-26T21:49:10Z

of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick Acked-by: Peter Korsgaard Acked-by: Timur Tabi Acked-by: Patrice Chotard Signed-off-by: Greg Kroah-Hartman

tty: serial: xilinx_uartps: Use Macro for ttyPS0

2015-03-07T02:28:57Z

All instances of "ttyPS" use this macro except for this one. Convert it. Signed-off-by: Peter Crosthwaite Acked-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

tty: xuartps: Fix RX hang, and TX corruption in termios call

2015-02-02T18:11:25Z

The implementation of flushing the RX FIFO breaks in a number of cases, it is impossible to ensure an complete flush of the RX FIFO due to the hardware not allowing the use of the FIFOs when the receiver is disabled (Reading from the FIFO register does not remove it from the FIFO when the RX_EN=0 or RX_DIS=1). Additionally during an initial set_termios call where RX_DIS=1 causes a hang waiting forever for the RX FIFO to empty. On top of this the FIFO will be cleared by the use of the RXRST bits on the Control Register, making the RX flush pointless (as it does not preserve the data read anyway). Due to the TXRST the TX FIFO and transmitter can be interrupted during frame trasmission, causing corruption and additionally data lost in the FIFO. Most other serial drivers do not flush or clear the FIFOs during a termios configuration change and as such do not have issues with corruption. For this UART controller is it required that the TXRST/RXRST bit be flagged during the change, this means that the data in the FIFO will be dropped when changing configuration. In order to prevent data loss and corruption of the transmitted data, wait until the TX FIFO is empty before changing the configuration. The performance of this may cause the set_termios call to take a longer amount of time especially on lower baud rates, however it is comparable to the same performance hit that a console_write call costs. Signed-off-by: Nathan Rossi Acked-by: Anirudha Sarangi Acked-by: Harini Katakam Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

tty: xuartps: Add support for setting modem control signals

2014-11-06T22:57:27Z

Add support for setting the state of the DTR and RTS signals. Acked-by: Soren Brinkmann Signed-off-by: Lars-Peter Clausen Signed-off-by: Greg Kroah-Hartman