kernel/drivers/rtc/rtc-tps65910.c, branch linux-4.1.y

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31Z

A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang

drivers/rtc/rtc-tps65910.c: fix potential NULL-pointer dereference

2014-08-08T22:57:20Z

The interrupt handler gets the driver data associated with the RTC device and doesn't check it for validity. This can cause a NULL pointer being dereferenced when and interrupt fires before the driver data was properly set up. Fix this by setting the driver data earlier (before the interrupt is requested). Signed-off-by: Thierry Reding Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: remove unnecessary include

2013-11-13T03:09:31Z

Currently, driver includes 'pm_runtime.h' which is not used anywhere in code hence remove this unnecessory inclusion. Signed-off-by: Manish Badarkhe Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: fix incorrect return value on error

2013-04-30T01:28:33Z

'ret' was not initialized to correct error value before returning. Since 'irq' is also being tested for 0, we cannot return irq itself as it means function is success even though we are returning before completing the probe. Signed-off-by: Sachin Kamat Acked-by: Venu Byravarasu Cc: Chiwoong Byun Cc: Jonghwa Lee Cc: Laxman dewangan Cc: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

rtc: rtc-tps65910: switch to using SIMPLE_DEV_PM_OPS

2013-04-30T01:28:33Z

Switch to using the SIMPLE_DEV_PM_OPS macro to declare the driver's pm_ops. It reduces code size. Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

rtc: rtc-tps65910: use devm_rtc_device_register()

2013-04-30T01:28:27Z

devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: set irq flag to IRQF_EARLY_RESUME during irq request

2013-02-22T01:22:28Z

All interrupt get disabled during system suspend and enabled during system resume. The enabling/disabling of interrupt happen in sequence of interrupt registration with framework. Therefore, in resume, the parent interrupt of this device enabled before the RTC irq interrupt enabled. If RTC is enabled for alarm wake and if system wake by alarm then there is interrupt pending for RTC. In resume, the parent interrupt get enabled before the rtc interrupt and hence ISR get served. In ISR, it founds that rtc interrupt is disabled and so it does not call the rtc isr handler and hence it misses the interrupt. Setting flag for early resume so that rtc interrupt get enabled before parent interrupt and so rtc interrupt get enabled when parent interrupt handler check for interrupt of device and call the rtc handler if it is there. This way it will not miss the interrupt. Signed-off-by: Laxman Dewangan Cc: Mark Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: use sleep_pm_ops macro for initialising suspend/resume callbacks

2013-02-22T01:22:28Z

Use SET_SYSTEM_SLEEP_PM_OPS for setting suspend/resume callbacks for dev_pm_ops. Signed-off-by: Laxman Dewangan Cc: Mark Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: remove unnecessary irq stat save and restore

2013-02-22T01:22:28Z

The driver stores the interrupt enable register before going to suspend and restore in resume. Also it enables alarm before going to suspend. The driver only write the Interrupt enable register for enabling ALARM and does not enable any other bits. So it is not require to save complete register and enable ALARM interrupt before suspend and restore in resume. Also ALARM interrupt already enable if alarm is enabled before going to suspend and hence it is not require to enable explictly in suspend. Removing such above code. Signed-off-by: Laxman Dewangan Cc: Mark Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

drivers/rtc/rtc-tps65910.c: enable/disable wake in suspend/resume

2013-02-22T01:22:28Z

Making the rtc driver as wakeup capabale and leaving the wake enable/disable decision to user space through a sysfs attribute. In suspend, enable wake if device wakeup enabled. In resume disable wake again. This change is inline with the Documentation/power/devices.txt# /sys/devices/.../power/wakeup files Signed-off-by: Laxman Dewangan Cc: Mark Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds