kernel/drivers/rtc/rtc-pcf2123.c, branch linux-4.16.y

rtc: pcf2123: Add missing error code assignment before test

2016-08-31T16:21:34Z

It is likely that checking the result of 'pcf2123_write_reg' is expected here. Also fix a small style issue. The '{' at the beginning of the function is misplaced. Fixes: 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip") Signed-off-by: Christophe JAILLET Signed-off-by: Alexandre Belloni

rtc: pcf2123: use sign_extend32() for sign extension

2016-06-04T13:50:44Z

Use sign_extend32() instead of open coding sign extension. Signed-off-by: Martin Kepplinger Signed-off-by: Alexandre Belloni

rtc: remove useless DRV_VERSION

2016-05-20T10:33:51Z

Many drivers are defining a DRV_VERSION. This is often only used for MODULE_VERSION and sometimes to print an info message at probe time. This is kind of pointless as they are all versionned with the kernel anyway. Also the core will print a message when a new rtc is found. Signed-off-by: Alexandre Belloni

rtc: pcf2123: implement read_offset and set_offset

2016-03-14T16:08:16Z

pcf2123 has an offset register, which can be used to make minor adjustments to the clock rate to compensate for temperature or a crystal that is not exactly right. Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

rtc: pcf2123: avoid resetting the clock if possible

2016-03-14T16:08:04Z

pcf2123 data sheet recommends a software reset when the chip is first powered on. This change avoids resetting the chip every time the driver is loaded, which has some negative effects. There are several registers including a clock rate adjustment that really should survive a reload of the driver (or reboot). In addition, stopping and restarting the clock to verify the chip is there is not a good thing once the time is set. According to the data sheet, the seconds register has a 1 in the high bit when the voltage has gotten low. We check for this condition, as well as whether the time retrieved from the chip is valid. We reset the rtc only if the time is not reliable and valid. This is sufficient for checking for the presence of the chip, as either all zeros or all 0xff will result in an invalid time/date Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

rtc: pcf2123: refactor chip reset into a function

2016-03-14T16:07:58Z

Refactor chip reset items into its own function, isolating it from the rest of the device probe. Subsequent commits will avoid calling this code. Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

rtc: pcf2123: clean up writes to the rtc chip

2016-03-14T16:07:53Z

Add new functions pcf2123_write(), and pcf2123_write_reg(). Use named defines for the values being written. This improves modularity and readability, and reduces lines of code. Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

rtc: pcf2123: clean up reads from the chip

2016-03-14T16:07:48Z

Put read operations into a function. This improves modularity and readability. Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

rtc: pcf2123: define registers and bit macros

2016-03-14T16:07:40Z

Add defines for all 16 registers in the pcf2123. Add defines for useful bits from several registers I've tried to document all the registers, and as best as possible, all the special bits they employ Use BIT() wherever possible in the bit definitions Signed-off-by: Joshua Clayton Signed-off-by: Alexandre Belloni

spi: Drop owner assignment from spi_drivers

2015-10-28T01:30:17Z

An spi_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Andrew F. Davis Acked-by: Jonathan Cameron Signed-off-by: Mark Brown