kernel/drivers/rtc/rtc-omap.c, branch linux-5.1.y

rtc: omap: Use define directive for PIN_CONFIG_ACTIVE_HIGH

2018-11-12T22:14:06Z

Clang warns when one enumerated type is implicitly converted to another: drivers/rtc/rtc-omap.c:574:21: warning: implicit conversion from enumeration type 'enum rtc_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] {"ti,active-high", PIN_CONFIG_ACTIVE_HIGH, 0}, ~ ^~~~~~~~~~~~~~~~~~~~~~ drivers/rtc/rtc-omap.c:579:12: warning: implicit conversion from enumeration type 'enum rtc_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] PCONFDUMP(PIN_CONFIG_ACTIVE_HIGH, "input active high", NULL, false), ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/pinctrl/pinconf-generic.h:163:11: note: expanded from macro 'PCONFDUMP' .param = a, .display = b, .format = c, .has_arg = d \ ^ 2 warnings generated. It is expected that pinctrl drivers can extend pin_config_param because of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion isn't an issue. Most drivers that take advantage of this define the PIN_CONFIG variables as constants, rather than enumerated values. Do the same thing here so that Clang no longer warns. Link: https://github.com/ClangBuiltLinux/linux/issues/144 Signed-off-by: Nathan Chancellor Signed-off-by: Alexandre Belloni

rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec

2018-08-27T20:51:57Z

Cut down the shutdown time from 2 seconds to 1 sec. In case of roll over try again. Signed-off-by: Keerthy Reviewed-by: Johan Hovold Signed-off-by: Alexandre Belloni

rtc: omap: use of_device_is_system_power_controller function

2018-08-27T20:51:56Z

Use of_device_is_system_power_controller instead of manually reading the system-power-controller property from the device tree node. Reviewed-by: Johan Hovold Signed-off-by: Keerthy Signed-off-by: Alexandre Belloni

rtc: omap: drop unnecessary register unlock around reads

2018-07-12T18:31:21Z

Drop unnecessary register write-unlock around two read accesses. Signed-off-by: Johan Hovold Signed-off-by: Alexandre Belloni

rtc: omap: add missing register lock in error path

2018-07-12T18:31:19Z

For completeness re-lock the registers also in the power-off error path. Signed-off-by: Johan Hovold Signed-off-by: Alexandre Belloni

rtc: omap: fix resource leak in registration error path

2018-07-12T18:31:18Z

Make sure to deregister the pin controller in case rtc registration fails. Fixes: 57072758623f ("rtc: omap: switch to rtc_register_device") Cc: stable # 4.14 Cc: Alexandre Belloni Signed-off-by: Johan Hovold Signed-off-by: Alexandre Belloni

rtc: omap: fix potential crash on power off

2018-07-12T18:31:17Z

Do not set the system power-off callback and omap power-off rtc pointer until we're done setting up our device to avoid leaving stale pointers around after a late probe error. Fixes: 97ea1906b3c2 ("rtc: omap: Support ext_wakeup configuration") Cc: stable # 4.9 Cc: Marcin Niestroj Cc: Tony Lindgren Signed-off-by: Johan Hovold Acked-by: Tony Lindgren Reviewed-by: Marcin Niestroj Signed-off-by: Alexandre Belloni

rtc: omap: stop validating rtc_time in .set_time and .set_alarm

2018-03-02T09:12:21Z

The RTC core is always validating the rtc_time struct before calling .set_time or .set_alarm. It is not necessary to do it again. Also, rtc_time_to_tm never generates an invalid rtc_tm (it can be out of range though). Signed-off-by: Alexandre Belloni

rtc: omap: call rtc_nvmem_register()

2018-03-01T09:49:20Z

Call rtc_nvmem_register instead of letting the core do it and stop using the nvmem_config member of struct rtc_device. Signed-off-by: Alexandre Belloni

rtc: omap: fix unbalanced clk_prepare_enable/clk_disable_unprepare

2017-12-18T22:05:11Z

There are 2 error paths after clk_prepare_enable() was called, where clk_disable_unprepare() is missing. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek Signed-off-by: Alexandre Belloni