kernel/drivers/platform/chrome/cros_ec_lpc_mec.c, branch linux-6.9.y

platform/chrome: cros_ec_lpc_mec: remove cros_ec_lpc_mec_destroy()

2022-11-01T02:33:02Z

It's pointless (and invalid) to destroy a statically allocated mutex in cros_ec_lpc_mec_destroy(). Let's remove it. Signed-off-by: Tzung-Bi Shih Reviewed-by: Guenter Roeck Reviewed-by: Brian Norris Link: https://lore.kernel.org/r/20221031050657.3899359-1-tzungbi@kernel.org

platform/chrome: cros_ec_lpc: Use DEFINE_MUTEX() for mutex lock

2021-04-21T08:00:30Z

mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin Signed-off-by: Enric Balletbo i Serra Link: https://lore.kernel.org/r/20210409095138.2293869-1-yebin10@huawei.com

platform/chrome: cros_ec_lpc_mec: Fix kernel-doc comment first line

2019-06-20T10:00:32Z

kernel-doc comments have a prescribed format. To be _particularly_ correct we should also capitalise the brief description and terminate it with a period. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Nick Crews

platform/chrome: cros_ec: Remove cros_ec dependency in lpc_mec

2019-02-11T09:07:40Z

In order to allow this code to be re-used, remove the dependency on the rest of the cros_ec code from the cros_ec_lpc_mec functions. Instead of using a hardcoded register base address of 0x800 have this be passed in to cros_ec_lpc_mec_init(). The existing cros_ec use case now passes in the 0x800 base address this way. There are some error checks that happen in cros_ec_lpc_mec_in_range() that probably shouldn't be there, as they are checking kernel-space callers and not user-space input. However, we'll just do the refactor in this patch, and in a future patch might remove this error checking and fix all the instances of code that calls this. There's a similar problem in cros_ec_lpc_read_bytes(), where we return a checksum, but on error just return 0. This should probably be changed so that it returns int, but we don't want to have to mess with all the calling code for this fix. Maybe we'll come back through later and fix this. Signed-off-by: Duncan Laurie Signed-off-by: Nick Crews Signed-off-by: Enric Balletbo i Serra

platform/chrome: cros_ec_lpc: switch to SPDX identifier

2019-02-01T09:13:06Z

Adopt the SPDX license identifier headers to ease license compliance management. Also remove the license boiler-plate and redundant driver description. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck

platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform.

2018-09-07T07:56:36Z

The cros-ec-lpc driver lives in drivers/platform because is platform specific, however there are two includes (cros_ec_lpc_mec.h and cros_ec_lpc_reg.h) that lives in include/linux/mfd. These two includes are only used for the platform driver and are not really related to the MFD subsystem, so move the includes from include/linux/mfd to drivers/platform/chrome. Signed-off-by: Enric Balletbo i Serra Signed-off-by: Benson Leung

platform/chrome: cros_ec_lpc: Add support for mec1322 EC

2017-06-23T23:12:01Z

This adds support for the ChromeOS LPC Microchip Embedded Controller (mec1322) variant. mec1322 accesses I/O region [800h, 9ffh] through embedded memory interface (EMI) rather than LPC. Signed-off-by: Shawn Nematbakhsh Signed-off-by: Thierry Escande Acked-by: Lee Jones Signed-off-by: Benson Leung