kernel/drivers/platform/chrome/chromeos_laptop.c, branch linux-6.9.y

platform/chrome: fix double-free in chromeos_laptop_prepare()

2022-08-22T06:56:45Z

If chromeos_laptop_prepare_i2c_peripherals() fails after allocating memory for 'cros_laptop->i2c_peripherals', this memory is freed at 'err_out' label and nonzero value is returned. Then chromeos_laptop_destroy() is called, resulting in double-free error. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rustam Subkhankulov Fixes: 5020cd29d8bf ("platform/chrome: chromeos_laptop - supply properties for ACPI devices") Reviewed-by: Dmitry Torokhov Signed-off-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20220813220843.2373004-1-subkhankulov@ispras.ru

platform/chrome: chromeos_laptop - Prepare complete software nodes

2021-04-10T19:43:02Z

The older device property API is going to be removed soon and that will affect also I2C subystem. Supplying complete software nodes instead of only the properties in them for the I2C devices. Signed-off-by: Heikki Krogerus Acked-by: Enric Balletbo i Serra Signed-off-by: Wolfram Sang

platform/chrome: chromeos_laptop: make I2C API conversion complete

2020-03-27T17:25:32Z

When converting to i2c_new_scanned_device(), it was overlooked that a conversion to i2c_new_client_device() was also needed. Fix it. Fixes: c82ebf1bf738 ("platform/chrome: chromeos_laptop: Convert to i2c_new_scanned_device") Signed-off-by: Wolfram Sang Signed-off-by: Enric Balletbo i Serra

platform/chrome: chromeos_laptop: Convert to i2c_new_scanned_device

2019-12-16T15:22:44Z

Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Signed-off-by: Wolfram Sang Signed-off-by: Enric Balletbo i Serra

platform/chrome: chromeos_laptop: drop checks of NULL-safe functions

2019-08-26T13:15:52Z

No need to check the argument of i2c_unregister_device() and property_entries_free() because the functions do check it. Signed-off-by: Wolfram Sang Signed-off-by: Enric Balletbo i Serra

platform/chrome: chromeos_laptop: use pci_dev_id() helper

2019-04-29T21:13:06Z

Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit Signed-off-by: Bjorn Helgaas Acked-By: Benson Leung

platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes

2018-05-29T22:11:04Z

Celes has newer touch controller (compared to the controllers used in older BayTrail-based devices) and so uses the same button mapping as Samus. This fixes the issue with mouse button being stuck in pressed state after the first click. Reported-by: Sultan Alsawaf Signed-off-by: Dmitry Torokhov Signed-off-by: Benson Leung

platform/chrome: chromeos_laptop - supply properties for ACPI devices

2018-05-23T19:48:31Z

BayTrail-based and newer Chromebooks describe their peripherals in ACPI; unfortunately their description is not complete, and peripherals drivers, such as driver for Atmel Touch controllers, has to resort to DMI-matching to configure the peripherals properly. To avoid polluting peripheral driver code, let's teach chromeos_laptop driver to supply missing data via generic device properties. Note we supply "compatible" string for Atmel peripherals not because it is needed for matching devices and driver (matching is still done on ACPI HID entries), but because peripherals driver will be using presence of "compatible" property to determine if device properties have been attached to the device, and fail to bind if they are absent. Signed-off-by: Dmitry Torokhov Signed-off-by: Benson Leung

platform/chrome: chromeos_laptop - discard data for unneeded boards

2018-04-10T05:52:17Z

Mark board data as __intconst/__initdata and make a copy of appropriate entry once we identified the board we are running on. The rest of the data will be discarded once the kernel finished booting (or module finished loading). Signed-off-by: Dmitry Torokhov Signed-off-by: Benson Leung

platform/chrome: chromeos_laptop - use device properties for Pixel

2018-04-10T05:51:22Z

Now that Atmel driver uses generic device properties we can use them instead of platform data when setting up touchpad on the original Google Pixel. Signed-off-by: Dmitry Torokhov Signed-off-by: Benson Leung