kernel/drivers/net/wireless/rsi, branch linux-4.1.y

rsi: Fix possible leak when loading firmware

2015-10-22T21:43:24Z

commit a8b9774571d46506a0774b1ced3493b1245cf893 upstream. Commit 5d5cd85ff441 ("rsi: Fix failure to load firmware after memory leak fix and fix the leak") also added a check on the allocation of DMA-accessible memory that may directly return. In that case the already allocated firmware data is leaked. Make sure the data is always freed correctly. Detected by Coverity CID 1316519. Fixes: 5d5cd85ff441 ("rsi: Fix failure to load firmware after memory leak fix and fix the leak") Signed-off-by: Christian Engelmayer Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman

rsi: Fix failure to load firmware after memory leak fix and fix the leak

2015-09-13T16:07:38Z

commit 5d5cd85ff441534a52f23f821d0a7c644d3b6cce upstream. Fixes commit eae79b4f3e82 ("rsi: fix memory leak in rsi_load_ta_instructions()") which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with kmalloc() in the original code. This patch reverts the commit and only calls "kfree()" to release the buffer after sending the data. This fixes the memory leak without breaking the driver. Add a comment to the kmemdup() calls to explain why this is done, and abort if memory allocation fails. Tested on a Topic Miami-Florida board which contains the rsi SDIO chip. Also added the same kfree() call to the USB glue driver. This was not tested on actual hardware though, as I only have the SDIO version. Fixes: eae79b4f3e82 ("rsi: fix memory leak in rsi_load_ta_instructions()") Signed-off-by: Mike Looijmans Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman

rsi: fix memory leak in rsi_load_ta_instructions()

2014-12-24T15:26:08Z

Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked. But duplication of firmware data here is useless, so the patch removes kmemdup() at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: Kalle Valo

rsi: fix memory leaks and error handling in rsi_91x_usb

2014-07-01T18:26:26Z

The patch fixes a couple of issues: - absence of deallocation of rsi_dev->rx_usb_urb[0] in the driver; - potential NULL pointer dereference because of lack of checks for memory allocation success in rsi_init_usb_interface(). By the way, it makes rsi_probe() returning error code instead of 1 and fixes comments regarding returning values. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: John W. Linville

rsi: GFP_ATOMIC is not needed in rsi_init_usb_interface()

2014-07-01T18:26:26Z

Signed-off-by: Alexey Khoroshilov Signed-off-by: John W. Linville

rsi: Fixed warnings reported by static code analyzers.

2014-06-25T19:40:41Z

Fixed a warning related to incorrect return type and removed an unnecessary semi colon. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville

rsi: Fixed errors and warnings reported by static code analyzers.

2014-06-25T19:40:40Z

Fixed a potential buffer overflow in 'rsi_rates' and a sparse warning related to difference in endianness in rsi_91x_mgmt.c. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville

rsi: Changes for 40MHz

2014-06-19T19:49:23Z

Added code required for 40MHz. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville

rsi: Adding support for host based bgscan.

2014-06-19T19:49:23Z

Added support for host based bgscan. The h/w queues are blocked while bgscan is being performed and after coming to the connected channel, the queues are unblocked. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville

rsi: Adding support for 5GHz

2014-06-19T19:49:23Z

Adding support for 5GHz. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville