kernel/drivers/net/wireless/rsi/rsi_91x_debugfs.c, branch linux-6.2.y

rsi: make array fsm_state static const, makes object smaller

2021-08-29T08:32:01Z

Don't populate the array fsm_state on the stack but instead it static const. Makes the object code smaller by 154 bytes: Before: text data bss dec hex filename 9213 3904 0 13117 333d .../wireless/rsi/rsi_91x_debugfs.o After: text data bss dec hex filename 8995 3968 0 12963 32a3 .../wireless/rsi/rsi_91x_debugfs.o (gcc version 10.3.0) Signed-off-by: Colin Ian King Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210819125018.8577-1-colin.king@canonical.com

rsi: Source file headers are not suitable for kernel-doc

2020-09-01T09:22:40Z

Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_debugfs.c:21: warning: Incorrect use of kernel-doc format: * rsi_sdio_stats_read() - This function returns the sdio status of the driver. drivers/net/wireless/rsi/rsi_91x_debugfs.c:28: warning: Function parameter or member 'seq' not described in 'rsi_sdio_stats_read' drivers/net/wireless/rsi/rsi_91x_debugfs.c:28: warning: Function parameter or member 'data' not described in 'rsi_sdio_stats_read' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200821071644.109970-21-lee.jones@linaro.org

rsi: fix spelling mistakes

2019-02-19T15:08:47Z

Trivial fixes to spelling mistakes in various files in rsi folder. Signed-off-by: Siva Rebbagondla Signed-off-by: Kalle Valo

rsi: no need to check return value of debugfs_create functions

2019-02-01T12:38:21Z

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kalle Valo Cc: linux-wireless@vger.kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Kalle Valo

rsi: add version information

2017-09-25T08:25:23Z

We will dump information about firmware version, firmware file name and operating mode during initialization. Signed-off-by: Pavani Muthyala Signed-off-by: Amitkumar Karwar Signed-off-by: Kalle Valo

rsi: changes in eeprom read frame

2017-07-28T14:22:33Z

EEPROM read frame is sent during device initialization to read mac address. The format of the frame is modified in firmware to include eeprom length and offset. This frame does not return firmware version now. Also same frame is sent again to read rf type and band information. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar Signed-off-by: Kalle Valo

rsi: use BUILD_BUG_ON check for fsm_state

2017-07-28T14:22:32Z

Whenever new fsm_state enum element is added, fsm_state array also needs to be updated. If this change is missed, we may end up doing invalid access in array. BUILD_BUG_ON check will help to avoid this problem. Signed-off-by: Amitkumar Karwar Signed-off-by: Kalle Valo

rsi: add in missing RSI_FSM_STATES into array fsm_state

2017-06-28T17:54:14Z

Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state was not updated to match. This can lead to an array overrun when accessing the latter two states in fsm_state. Fix this by adding in the missing states. Detected by CoverityScan, CID#1398379 ("Illegal address computation") Fixes: 9920322ccd8e ("rsi: add tx frame for common device configuration") Fixes: 015e367494c1 ("rsi: Register interrupt handler before firmware load") Signed-off-by: Colin Ian King Signed-off-by: Kalle Valo

rsi: Mapping the debugfs stats to the correct s/w queues.

2014-06-19T19:49:21Z

Changed the queue numbers to macros, and corrected the mappings. Signed-off-by: Jahnavi Meher Signed-off-by: John W. Linville

rsi: Potential null pointer derefernce issue fixed.

2014-04-09T17:55:53Z

Signed-off-by: Fariya Fatima Signed-off-by: John W. Linville