kernel/drivers/net/wan/pc300too.c, branch linux-6.18.y

net: split out ndo_siowandev ioctl

2021-07-27T19:11:45Z

In order to further reduce the scope of ndo_do_ioctl(), move out the SIOCWANDEV handling into a new network device operation function. Adjust the prototype to only pass the if_settings sub-structure in place of the ifreq, and remove the redundant 'cmd' argument in the process. Cc: Krzysztof Halasa Cc: "Jan \"Yenya\" Kasprzak" Cc: Kevin Curtis Cc: Zhao Qiang Cc: Martin Schiller Cc: Jiri Slaby Cc: linux-x25@vger.kernel.org Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller

wan: use ndo_siocdevprivate

2021-07-27T19:11:44Z

The wan drivers each support some custom SIOCDEVPRIVATE ioctls, plus the common SIOCWANDEV command. Split these so the ioctl callback only deals with SIOCWANDEV and the rest is handled by ndo_siocdevprivate. It might make sense to also split out SIOCWANDEV into a separate callback in order to eventually remove ndo_do_ioctl entirely. Cc: Krzysztof Halasa Cc: Kevin Curtis Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller

net: pc300too: fix the comments style issue

2021-06-11T19:58:12Z

Networking block comments don't use an empty /* line, use /* Comment... This patch fixes the comments style issues. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: pc300too: add some required spaces

2021-06-11T19:58:12Z

Add spaces required before the open parenthesis '('. Add spaces required after that close brace '}'. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: pc300too: replace comparison to NULL with "!card->plxbase"

2021-06-11T19:58:12Z

According to the chackpatch.pl, comparison to NULL could be written "!card->plxbase". Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: pc300too: remove redundant initialization for statics

2021-06-11T19:58:12Z

Should not initialise statics to 0. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: pc300too: move out assignment in if condition

2021-06-11T19:58:11Z

Should not use assignment in if condition. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: pc300too: fix the code style issue about "foo * bar"

2021-06-11T19:58:11Z

Fix the checkpatch error as "foo * bar" and should be "foo *bar". Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: pc300too: add blank line after declarations

2021-06-11T19:58:11Z

This patch fixes the checkpatch error about missing a blank line after declarations. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: pc300too: remove redundant blank lines

2021-06-11T19:58:11Z

This patch removes some redundant blank lines. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller