kernel/drivers/net/phy/phy-c45.c, branch linux-5.1.y

net: phy: use phy_modify_mmd_changed in genphy_c45_an_config_aneg

2019-03-04T21:10:10Z

As can be seen from the usage of the return value, we should use phy_modify_mmd_changed() here. Fixes: 9a5dc8af4416 ("net: phy: add genphy_c45_an_config_aneg") Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller

net: phy: remove gen10g_no_soft_reset

2019-03-04T05:47:57Z

genphy_no_soft_reset and gen10g_no_soft_reset are both the same no-ops, one is enough. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller

net: phy: don't export gen10g_read_status

2019-03-04T05:47:42Z

gen10g_read_status is deprecated, therefore stop exporting it. We don't want to encourage anybody to use it. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller

net: phy: remove gen10g_config_init

2019-03-04T05:47:42Z

ETHTOOL_LINK_MODE_10000baseT_Full_BIT is set anyway in the supported and advertising bitmap because it's part of PHY_10GBIT_FEATURES. And all users of gen10g_config_init use PHY_10GBIT_FEATURES. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller

net: phy: remove gen10g_suspend and gen10g_resume

2019-03-04T05:47:42Z

phy_suspend() and phy_resume() are no-ops anyway if no callback is defined. Therefore we don't need these stubs. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller

net: phy: check PMAPMD link status only in genphy_c45_read_link

2019-02-25T01:42:58Z

The current code reports a link as up if all devices (except a few blacklisted ones) report the link as up. This breaks Aquantia AQCS109 for lower speeds because on this PHY the PCS link status reflects a 10G link only. For Marvell there's a similar issue, therefore PHYXS device isn't checked. There may be more PHYs where depending on the mode the link status of only selected devices is relevant. For now it seems to be sufficient to check the link status of the PMAPMD device only. Leave the loop in the code to be prepared in case we have to add functionality to check more than one device, depending on the mode. Successfully tested on a board with an AQCS109. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller

net: phy: let genphy_c45_read_abilities also check aneg capability

2019-02-24T20:34:47Z

When using genphy_c45_read_abilities() as get_features callback we also have to set the autoneg capability in phydev->supported. Signed-off-by: Heiner Kallweit Reviewed-by: Maxime Chevallier Signed-off-by: David S. Miller

net: phy: add genphy_c45_read_status

2019-02-23T22:12:09Z

Similar to genphy_read_status() for Clause 22 add a generic read_status function for Clause 45. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller

net: phy: don't change modes we don't care about in genphy_c45_read_lpa

2019-02-23T22:12:09Z

Because 1000BaseT isn't covered by Clause 45, the 1000BaseT flags in phydev->lp_advertising may have been set based on vendor registers already. genphy_c45_read_lpa() would clear these flags as of today. Therefore switch to mii_lpa_mod_linkmode_lpa_t. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller

net: phy: add genphy_c45_check_and_restart_aneg

2019-02-21T21:03:06Z

This function will be used by config_aneg callback implementations of PHY drivers and allows to reduce boilerplate code. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller