kernel/drivers/net/ethernet/xilinx/xilinx_emaclite.c, branch linux-4.3.y

net: fix phy refcounting in a bunch of drivers

2015-09-25T06:04:53Z

of_phy_find_device() increments the phy struct device refcount, which we need to properly balance. Add code to network drivers using this function to ensure that the struct device refcount is correctly balanced. For xgene, looking back in the history, we should be able to use of_phy_connect() with a zero flags argument for the DT case as this is how the driver used to operate prior to de7b5b3d790a ("net: eth: xgene: change APM X-Gene SoC platform ethernet to support ACPI"). This leaves the Cavium Thunder BGX unfixed; fixing this driver is a complicated task, one which the maintainers need to be involved with. Signed-off-by: Russell King Signed-off-by: David S. Miller

ethernet: Use bool function returns of true/false instead of 1/0

2015-03-31T18:09:49Z

Use bool constants as the return values instead of 1 and 0. Signed-off-by: Joe Perches Acked-by: Jeff Kirsher Signed-off-by: David S. Miller

net: xilinx: constify of_device_id array

2015-03-17T19:00:22Z

of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick Signed-off-by: David S. Miller

net: Xilinx: fix error return code

2015-01-01T00:19:00Z

Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller

net: Xilinx: Deletion of unnecessary checks before two function calls

2014-11-21T20:14:12Z

The functions kfree() and of_node_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Soren Brinkmann Signed-off-by: David S. Miller

net: xilinx: Remove .owner field for driver

2014-08-14T21:38:54Z

There is no need to init .owner field. Based on the patch from Peter Griffin "mmc: remove .owner field for drivers using module_platform_driver" This patch removes the superflous .owner field for drivers which use the module_platform_driver API, as this is overriden in platform_driver_register anyway." Signed-off-by: Michal Simek Signed-off-by: David S. Miller

xilinx: Fix compiler warning

2014-06-23T00:14:56Z

The time comparsion functions require arguments of type unsigned long instead of (signed) long. Signed-off-by: Manuel Schölling Signed-off-by: David S. Miller

xilinx: Use time_before_eq()

2014-05-22T19:50:13Z

To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling Signed-off-by: David S. Miller

net: emaclite: remove empty MDIO bus reset function

2014-03-28T05:38:02Z

xemaclite_mdio_reset() does nothing useful and is optional for the MDIO bus code, so let's just remove it. Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller

xilinx_emaclite: Call dev_consume_skb_any instead of dev_kfree_skb.

2014-03-25T04:19:22Z

Replace dev_kfree_skb with dev_consume_skb_any in xemaclite_send which can be called in hard irq and other contexts. xemacelite_send only frees skbs that it has successfully transmitted. Signed-off-by: "Eric W. Biederman"