kernel/drivers/net/ethernet/sfc/tc_counters.c, branch linux-6.2.yHosts the 0x221E linux distro kernel.https://universe.0xinfinity.dev/distro/kernel/atom?h=linux-6.2.y2022-11-23T13:47:51Zsfc: ensure type is valid before updating seen_gen2022-11-23T13:47:51ZEdward Creeecree.xilinx@gmail.com2022-11-21T21:37:08Zurn:sha1:e80bd08fd75a644e2337fb535c1afdb6417357ff
In the case of invalid or corrupted v2 counter update packets,
efx_tc_rx_version_2() returns EFX_TC_COUNTER_TYPE_MAX. In this case
we should not attempt to update generation counts as this will write
beyond the end of the seen_gen array.
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527356 ("Memory - illegal accesses")
Fixes: 25730d8be5d8 ("sfc: add extra RX channel to receive MAE counter updates on ef100")
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
sfc: implement counters readout to TC stats2022-11-16T09:07:03ZEdward Creeecree.xilinx@gmail.com2022-11-14T13:16:01Zurn:sha1:50f8f2f7fbf2f237a7938890f46c3edce0f51501
On FLOW_CLS_STATS, look up the MAE counter by TC cookie, and report the
change in packet and byte count since the last time FLOW_CLS_STATS read
them.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
sfc: accumulate MAE counter values from update packets2022-11-16T09:07:02ZEdward Creeecree.xilinx@gmail.com2022-11-14T13:15:58Zurn:sha1:c4bad432b95a91a4f123159e5b8220bd026dc166
Add the packet and byte counts to the software running total, and store
the latest jiffies every time the counter is bumped.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
sfc: add functions to allocate/free MAE counters2022-11-16T09:07:02ZEdward Creeecree.xilinx@gmail.com2022-11-14T13:15:57Zurn:sha1:0363aa295781a3ad160b2b562dc0460b331db06c
efx_tc_flower_get_counter_index() will create an MAE counter mapped to
the passed (TC filter) cookie, or increment the reference if one already
exists for that cookie.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
sfc: add hashtables for MAE counters and counter ID mappings2022-11-16T09:07:02ZEdward Creeecree.xilinx@gmail.com2022-11-14T13:15:56Zurn:sha1:19a0c989104a08c07c97f8713d083cc635ef8d01
Nothing populates them yet.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
sfc: add extra RX channel to receive MAE counter updates on ef1002022-11-16T09:07:02ZEdward Creeecree.xilinx@gmail.com2022-11-14T13:15:55Zurn:sha1:25730d8be5d8bc691ed89dca065f2b229b244ae0
Currently there is no counter-allocating machinery to connect the
resulting counter update values to; that will be added in a
subsequent patch.
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>