kernel/drivers/net/ethernet/sfc/tc_counters.c, branch linux-6.18.y

sfc: Convert to use ERR_CAST()

2024-08-30T18:10:02Z

As opposed to open-code, using the ERR_CAST macro clearly indicates that this is a pointer to an error value and a type conversion was performed. Signed-off-by: Shen Lichuan Reviewed-by: Jacob Keller Reviewed-by: Martin Habets Reviewed-by: Edward Cree Link: https://patch.msgid.link/20240829021253.3066-1-shenlichuan@vivo.com Signed-off-by: Jakub Kicinski

sfc: handle error pointers returned by rhashtable_lookup_get_insert_fast()

2023-09-21T08:37:16Z

Several places in TC offload code assumed that the return from rhashtable_lookup_get_insert_fast() was always either NULL or a valid pointer to an existing entry, but in fact that function can return an error pointer. In that case, perform the usual cleanup of the newly created entry, then pass up the error, rather than attempting to take a reference on the old entry. Fixes: d902e1a737d4 ("sfc: bare bones TC offload on EF100") Reported-by: Dan Carpenter Signed-off-by: Edward Cree Link: https://lore.kernel.org/r/20230919183949.59392-1-edward.cree@amd.com Signed-off-by: Paolo Abeni

sfc: offload conntrack flow entries (match only) from CT zones

2023-08-09T10:14:38Z

No handling yet for FLOW_ACTION_MANGLE (NAT or NAPT) actions. Reviewed-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman Signed-off-by: Edward Cree Signed-off-by: David S. Miller

sfc: keep alive neighbour entries while a TC encap action is using them

2023-06-23T02:54:14Z

When processing counter updates, if any action set using the newly incremented counter includes an encap action, prod the corresponding neighbouring entry to indicate to the neighbour cache that the entry is still in use and passing traffic. Signed-off-by: Edward Cree Link: https://lore.kernel.org/r/20230621121504.17004-1-edward.cree@amd.com Signed-off-by: Jakub Kicinski

sfc: ensure type is valid before updating seen_gen

2022-11-23T13:47:51Z

In the case of invalid or corrupted v2 counter update packets, efx_tc_rx_version_2() returns EFX_TC_COUNTER_TYPE_MAX. In this case we should not attempt to update generation counts as this will write beyond the end of the seen_gen array. Reported-by: coverity-bot Addresses-Coverity-ID: 1527356 ("Memory - illegal accesses") Fixes: 25730d8be5d8 ("sfc: add extra RX channel to receive MAE counter updates on ef100") Signed-off-by: Edward Cree Reviewed-by: Kees Cook Signed-off-by: David S. Miller

sfc: implement counters readout to TC stats

2022-11-16T09:07:03Z

On FLOW_CLS_STATS, look up the MAE counter by TC cookie, and report the change in packet and byte count since the last time FLOW_CLS_STATS read them. Signed-off-by: Edward Cree Signed-off-by: David S. Miller

sfc: accumulate MAE counter values from update packets

2022-11-16T09:07:02Z

Add the packet and byte counts to the software running total, and store the latest jiffies every time the counter is bumped. Signed-off-by: Edward Cree Signed-off-by: David S. Miller

sfc: add functions to allocate/free MAE counters

2022-11-16T09:07:02Z

efx_tc_flower_get_counter_index() will create an MAE counter mapped to the passed (TC filter) cookie, or increment the reference if one already exists for that cookie. Signed-off-by: Edward Cree Signed-off-by: David S. Miller

sfc: add hashtables for MAE counters and counter ID mappings

2022-11-16T09:07:02Z

Nothing populates them yet. Signed-off-by: Edward Cree Signed-off-by: David S. Miller

sfc: add extra RX channel to receive MAE counter updates on ef100

2022-11-16T09:07:02Z

Currently there is no counter-allocating machinery to connect the resulting counter update values to; that will be added in a subsequent patch. Signed-off-by: Edward Cree Signed-off-by: David S. Miller