kernel/drivers/net/can/usb, branch linux-4.1.y

can: peak: fix potential bug in packet fragmentation

2018-03-01T03:09:39Z

[ Upstream commit d8a243af1a68395e07ac85384a2740d4134c67f4 ] In some rare conditions when running one PEAK USB-FD interface over a non high-speed USB controller, one useless USB fragment might be sent. This patch fixes the way a USB command is fragmented when its length is greater than 64 bytes and when the underlying USB controller is not a high-speed one. Signed-off-by: Stephane Grosjean Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: gs_usb: fix return value of the "set_bittiming" callback

2018-03-01T00:32:21Z

[ Upstream commit d5b42e6607661b198d8b26a0c30969605b1bf5c7 ] The "set_bittiming" callback treats a positive return value as error! For that reason "can_changelink()" will quit silently after setting the bittiming values without processing ctrlmode, restart-ms, etc. Signed-off-by: Wolfgang Grandegger Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: usb_8dev: cancel urb on -EPIPE and -EPROTO

2018-01-17T17:55:21Z

[ Upstream commit 12147edc434c9e4c7c2f5fee2e5519b2e5ac34ce ] In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: esd_usb2: cancel urb on -EPIPE and -EPROTO

2018-01-17T17:55:21Z

[ Upstream commit 7a31ced3de06e9878e4f9c3abe8f87d9344d8144 ] In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: ems_usb: cancel urb on -EPIPE and -EPROTO

2018-01-17T17:55:21Z

[ Upstream commit bd352e1adfe0d02d3ea7c8e3fb19183dc317e679 ] In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: kvaser_usb: cancel urb on -EPIPE and -EPROTO

2018-01-17T17:55:21Z

[ Upstream commit 6aa8d5945502baf4687d80de59b7ac865e9e666b ] In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: kvaser_usb: ratelimit errors if incomplete messages are received

2018-01-17T17:55:21Z

[ Upstream commit 8bd13bd522ff7dfa0eb371921aeb417155f7a3be ] Avoid flooding the kernel log with "Formate error", if incomplete message are received. Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback()

2018-01-17T17:55:21Z

[ Upstream commit e84f44eb5523401faeb9cc1c97895b68e3cfb78d ] The conditon in the while-loop becomes true when actual_length is less than 2 (MSG_HEADER_LEN). In best case we end up with a former, already dispatched msg, that got msg->len greater than actual_length. This will result in a "Format error" error printout. Problem seen when unplugging a Kvaser USB device connected to a vbox guest. warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: kvaser_usb: free buf in error paths

2018-01-17T17:55:21Z

[ Upstream commit 435019b48033138581a6171093b181fc6b4d3d30 ] The allocated buffer was not freed if usb_submit_urb() failed. Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin

can: kvaser_usb: Ignore CMD_FLUSH_QUEUE_REPLY messages

2017-11-06T04:54:38Z

[ Upstream commit e1d2d1329a5722dbecc9c278303fcc4aa01f8790 ] To avoid kernel warning "Unhandled message (68)", ignore the CMD_FLUSH_QUEUE_REPLY message for now. As of Leaf v2 firmware version v4.1.844 (2017-02-15), flush tx queue is synchronous. There is a capability bit indicating whether flushing tx queue is synchronous or asynchronous. A proper solution would be to query the device for capabilities. If the synchronous tx flush capability bit is set, we should wait for CMD_FLUSH_QUEUE_REPLY message, while flushing the tx queue. Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin