kernel/drivers/mtd/tests/oobtest.c, branch linux-5.1.y

mtd: mtd_oobtest: Handle bitflips during reads

2018-01-12T09:24:08Z

Reads from NAND devices usually trigger bitflips, this is an expected behavior. While bitflips are under a given threshold, the MTD core returns 0. However, when the number of corrected bitflips is above this same threshold, -EUCLEAN is returned to inform the upper layer that this block is slightly dying and soon the ECC engine will be overtaken so actions should be taken to move the data out of it. This particular condition should not be treated like an error and the test should continue. Signed-off-by: Miquel Raynal Signed-off-by: Boris Brezillon

mtd: kill the ecclayout->oobavail field

2016-03-08T00:23:09Z

ecclayout->oobavail is just redundant with the mtd->oobavail field. Moreover, it prevents static const definition of ecc layouts since the NAND framework is calculating this value based on the ecclayout->oobfree field. Signed-off-by: Boris Brezillon Signed-off-by: Brian Norris

mtd: mtd_oobtest: Fix the address offset with vary_offset case

2015-08-27T23:30:01Z

When vary_offset is set (e.g. test case 3), the offset is not always zero so memcmpshow() will show the wrong offset in the print message. To fix this we introduce a new function memcmpshowoffset() which takes offset as a parameter and displays the right offset and use it in the case where offset is non zero. The old memcmpshow() functionality is preserved by converting it into a macro with offset preset to 0. Signed-off-by: Roger Quadros Signed-off-by: Brian Norris

mtd: Make MTD tests cancelable

2015-04-06T01:12:53Z

I always go nuts when I start an MTD test on a slow device and have to wait forever until it finishes. From the debug output I already know what the issue is but I have to wait or reset the board hard. Resetting is often not an option (remote access, you don't want lose the current state, etc...). The solution is easy, check for pending signals at key positions in the code. Using that one can even stop a test by pressing CTRL-C as insmod/modprobe have SIGINT pending. Signed-off-by: Richard Weinberger Signed-off-by: Brian Norris

mtd: mtd_oobtest: Fix bitflip_limit usage in test case 3

2015-04-06T01:10:23Z

In test case 3, we set vary_offset to write at different offsets and lengths in the OOB available area. We need to do the bitflip_limit check while checking for 0xff outside the OOB offset + length area that we didn't modify during write. Signed-off-by: Roger Quadros [Brian: whitespace fixup] Signed-off-by: Brian Norris

mtd: tests: fix more potential integer overflows

2015-03-11T22:21:47Z

Caught by Coverity (CID #200625 and others) Signed-off-by: Brian Norris Cc: Akinobu Mita

mtd: oobtest: correct printf() format specifier for 'size_t'

2014-11-20T09:26:51Z

Fixes warning: drivers/mtd/tests/oobtest.c: In function 'memcmpshow': drivers/mtd/tests/oobtest.c:129: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'size_t' Signed-off-by: Brian Norris Cc: Roger Quadros Cc: Sekhar Nori

mtd: mtd_oobtest: add bitflip_limit parameter

2014-11-20T07:25:49Z

It is common for NAND devices to have bitflip errors. Add a bitflip_limit parameter to specify how many bitflips per page we can tolerate without flagging an error. By default zero bitflips are tolerated. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori Signed-off-by: Brian Norris

mtd: mtd_oobtest: Show the verification error location and data

2014-11-20T07:25:06Z

Add a function memcmpshow() that compares the 2 data buffers and shows the address:offset and data bytes on comparison failure. This function does not break at a comparison failure but runs the check for the whole data buffer. Use memcmpshow() instead of memcmp() for all the verification paths. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori Signed-off-by: Brian Norris

mtd: tests: fix integer overflow issues

2014-08-19T18:53:08Z

These multiplications are done with 32-bit arithmetic, then converted to 64-bit. We should widen the integers first to prevent overflow. This could be a problem for large (>4GB) MTD's. Detected by Coverity. Signed-off-by: Brian Norris Cc: Akinobu Mita