kernel/drivers/mmc/host/cb710-mmc.c, branch linux-6.9.y

mmc: cb710: Convert to platform remove callback returning void

2023-08-15T10:45:04Z

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Michał Mirosław Link: https://lore.kernel.org/r/20230727070051.17778-6-frank.li@vivo.com Signed-off-by: Ulf Hansson

mmc: cb710: Use new tasklet API

2021-02-15T09:43:23Z

This converts the driver to use the new tasklet API introduced in commit 12cc923f1ccc ("tasklet: Introduce new initialization API") Signed-off-by: Emil Renner Berthing Acked-by: Michał Mirosław Link: https://lore.kernel.org/r/20210208134551.39696-1-kernel@esmil.dk Signed-off-by: Ulf Hansson

mmc: cb710: Inform the mmc core about the maximum busy timeout

2020-05-28T09:22:13Z

Some commands uses R1B responses, which means the card may assert the DAT0 line to signal busy for a period of time, after it has received the command. The mmc core normally specifies the busy period for the command in the cmd->busy_timeout. Ideally the driver should respect it, but that requires quite some update of the code, so let's defer that to someone with the HW at hand. Instead, let's inform the mmc core about the maximum supported busy timeout in ->max_busy_timeout during ->probe(). This value corresponds to the fixed ~2s timeout of the polling loop, implemented in cb710_wait_for_event(). In this way, we let the mmc core validate the needed timeout, which may lead to that it converts from a R1B into a R1 response and then use CMD13 to poll for busy completion. In other words, this change enables support for commands with longer busy periods than 2s, like erase (CMD38) for example. Cc: Michał Mirosław Signed-off-by: Ulf Hansson Link: https://lore.kernel.org/r/20200414161413.3036-7-ulf.hansson@linaro.org

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19T15:09:55Z

Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation # extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 4122 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de Signed-off-by: Greg Kroah-Hartman

mmc: cb710: fix indentation issue in if block

2019-02-25T07:40:58Z

There is an if block that is not indented, fix this. Also add a break statement on the default case to clean up a cppcheck warning. Signed-off-by: Colin Ian King Signed-off-by: Ulf Hansson

mmc: cb710: Move away from using deprecated APIs

2013-10-31T00:26:37Z

Suspend and resume of cards are being handled from the protocol layer and consequently the mmc_suspend|resume_host APIs are deprecated. This means we can simplify the suspend|resume callbacks by removing the use of the deprecated APIs. Cc: Michał Mirosław Signed-off-by: Ulf Hansson Acked-by: Michał Mirosław Signed-off-by: Chris Ball

mmc: host: use platform_{get,set}_drvdata()

2013-06-27T15:13:02Z

Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Jingoo Han Acked-by: Michał Mirosław Signed-off-by: Chris Ball

mmc: remove use of __devexit

2012-11-28T20:28:18Z

CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton Cc: Manuel Lauss Cc: Chris Ball Cc: "Michał Mirosław" Cc: Jarkko Lavinen Cc: Venkatraman S Cc: Viresh Kumar Cc: Ian Molton Cc: Bruce Chang Cc: Harald Welte Cc: Pierre Ossman Acked-by: Guennadi Liakhovetski Signed-off-by: Greg Kroah-Hartman

mmc: remove use of __devinit

2012-11-28T20:28:18Z

CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton Cc: Chris Ball Cc: Manuel Lauss Cc: "Michał Mirosław" Cc: Jarkko Lavinen Cc: Venkatraman S Cc: Ian Molton Cc: Bruce Chang Cc: Harald Welte Cc: Pierre Ossman Acked-by: Ludovic Desroches Acked-by: Viresh Kumar Acked-by: Guennadi Liakhovetski Signed-off-by: Greg Kroah-Hartman

mmc: remove use of __devexit_p

2012-11-28T20:28:09Z

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Signed-off-by: Bill Pemberton Cc: Chris Ball Cc: "Michał Mirosław" Cc: Jarkko Lavinen Cc: Venkatraman S Cc: Ian Molton Cc: Bruce Chang Cc: Harald Welte Cc: Pierre Ossman Acked-by: Viresh Kumar Acked-by: Guennadi Liakhovetski Signed-off-by: Greg Kroah-Hartman