kernel/drivers/mmc/host/android-goldfish.c, branch linux-5.1.y

mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-21T14:06:17Z

The conversion to sg_copy_{from,to}_buffer has been done in the wrong way. sg_copy_to_buffer is a copy from an SG list to a linear buffer so it can't replace memcpy(dest, host->virt_base, data->sg->length) where dest is the virtual address of the SG. Same for sg_copy_from_buffer but in the opposite way. Signed-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 53d7e098ba08 ("mmc: android-goldfish: use sg_copy_{from,to}_buffer") Signed-off-by: Ulf Hansson

mmc: android-goldfish: use sg_copy_{from,to}_buffer

2018-05-21T13:49:19Z

This handles highmem pages, and also cleans up the code. Signed-off-by: Christoph Hellwig Signed-off-by: Ulf Hansson

mmc: android-goldfish: remove duplicate includes

2017-12-18T12:56:59Z

These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge Signed-off-by: Ulf Hansson

mmc: android-goldfish: remove logically dead code in goldfish_mmc_irq()

2017-08-30T12:01:23Z

Local variable transfer_error is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 1222110 Signed-off-by: Gustavo A. R. Silva Signed-off-by: Ulf Hansson

mmc: use new core function mmc_get_dma_dir

2017-04-24T19:41:52Z

Use new core function mmc_get_dma_dir(). Signed-off-by: Heiner Kallweit Signed-off-by: Ulf Hansson

Replace with globally

2016-12-24T19:46:01Z

This was entirely automated, using the script by Al: PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*' sed -i -e "s!$PATT!#include !" \ $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h) to do the replacement at the end of the merge window. Requested-by: Al Viro Signed-off-by: Linus Torvalds

mmc: android-goldfish: remove incorrect __iomem annotation

2015-09-01T12:19:11Z

Make sparse happy: drivers/mmc/host/android-goldfish.c:535:56: sparse: incorrect type in argument 3 (different address spaces) Signed-off-by: Christoph Hellwig Signed-off-by: Ulf Hansson

remove

2015-05-05T19:35:39Z

We don't have any arch specific scatterlist now that parisc switched over to the generic one. Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe

mmc: remove unnecessary platform_set_drvdata()

2013-05-26T18:23:23Z

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang Acked-by: Seungwon Jeon Acked-by: Shawn Guo Acked-by: Adrian Hunter Acked-by: Haojian Zhuang Acked-by: Jaehoon Chung Acked-by: Viresh Kumar Acked-by: Tony Prisk Signed-off-by: Chris Ball

mmc: android-goldfish: use resource_size()

2013-03-22T16:53:52Z

Use resource_size() instead of explicit calculation. This was found via make coccicheck. Signed-off-by: Silviu-Mihai Popescu Signed-off-by: Chris Ball